fix(anthropic): capture sampling params from extra_body - #480
Draft
walleseve wants to merge 2 commits into
Draft
Conversation
walleseve
force-pushed
the
fix/anthropic-extra-body-sampling
branch
from
August 25, 2026 20:15
98fa68e to
2579ad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Anthropic SDK 1.x removed
temperature,top_p, andtop_kfrom its typed method signatures while retaining them throughextra_body. The instrumentation ignored that mapping, so these request attributes disappeared from telemetry. Fixes #471.What
Fall back to numeric sampling values from
extra_bodywhen their named arguments are absent. Add extractor unit tests and make the existing sync/async coverage assert sampling attributes on both supported SDK generations.Why the approach
For backward compatibility reasons, when conflicting values are supplied in both locations, the code ensures that the original named values win:
Validation
weaverbinary unavailable locally; CI installs it)tox -e typechecktox -e precommitType of change
Checklist