-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve baggage performance #4466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I was curious about the results for larger baggage set, and opened #4468 with a benchmark so we can compare the results.
But, in summary the results for baggage size of 10000 were improved by ~8.4x
@gruebel Please add a changelog entry. This also shows that we have a very broad typing 😅 |
@xrmx done 🙂 |
@@ -41,6 +41,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
([#4458](https://github.com/open-telemetry/opentelemetry-python/pull/4458)) | |||
- pylint-ci updated python version to 3.13 | |||
([#4450](https://github.com/open-telemetry/opentelemetry-python/pull/4450)) | |||
- Improve performance of baggage operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong release 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry 🙈
Description
dict
and creates a copy before modifying it. If you are ok with it, then I can also remove thecopy()
and directly manipulate the baggage in thecontext
, which would further improve the performance.you can easily test it
Checklist: