Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(exporter): set user agent for otlp metrics exporter #4475

Merged
merged 7 commits into from
Mar 13, 2025

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Mar 11, 2025

Description

Update OTLP over HTTP exporter for metrics to ensure the user agent is set consistently with the logs and traces exporter.

Fixes #4474

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested to ensure the new header is set

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@codeboten codeboten requested a review from a team as a code owner March 11, 2025 22:26
@xrmx
Copy link
Contributor

xrmx commented Mar 12, 2025

@codeboten please add a changelog entry and would be great if you can create a basic TestOTLPMetricExporter with test_constructor_default as other signals

@codeboten
Copy link
Contributor Author

thanks for the review @xrmx, updated the changelog and added the test

@codeboten
Copy link
Contributor Author

not sure what happened to the contrib tests here...

@xrmx xrmx enabled auto-merge (squash) March 13, 2025 09:19
@xrmx xrmx merged commit fcb5e21 into open-telemetry:main Mar 13, 2025
385 checks passed
@codeboten codeboten deleted the codeboten/fix-metrics-ua branch March 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP exporter for metrics isn't setting the user agent string
4 participants