Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: remove duplicated env vars #4491

Merged
merged 3 commits into from
Mar 20, 2025
Merged

sdk: remove duplicated env vars #4491

merged 3 commits into from
Mar 20, 2025
+17 −61

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Mar 18, 2025

Running pyright at sdk/environment_variables:

__init__.py:568:1 - error: "OTEL_EXPORTER_OTLP_METRICS_ENDPOINT" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:577:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CERTIFICATE" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:595:1 - error: "OTEL_EXPORTER_OTLP_METRICS_HEADERS" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:603:1 - error: "OTEL_EXPORTER_OTLP_METRICS_TIMEOUT" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:619:1 - error: "OTEL_EXPORTER_OTLP_METRICS_COMPRESSION" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:717:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CLIENT_KEY" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:740:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CLIENT_CERTIFICATE" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)

@emdneto emdneto requested a review from a team as a code owner March 18, 2025 02:22
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2025
@pmcollins
Copy link
Member

Hi Emídio -- LGTM but would this be considered a breaking change?

@emdneto emdneto removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2025
@emdneto
Copy link
Member Author

emdneto commented Mar 18, 2025 •
edited
Loading

Hi Emídio -- LGTM but would this be considered a breaking change?

Hmm, I double-checked each variable, and they have the same name/value. You will still be able to import them. We can changelog it with Removed: if you want

@pmcollins
Copy link
Member

Hi Emídio -- LGTM but would this be considered a breaking change?

Hmm, I double-checked each variable, and they have the same name/value. You will still be able to import it. We can changelog it with Removed: if you want

Oh sorry, it's fine -- I didn't realize the duplicates were in the same file.

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 18, 2025
@emdneto
add changelog
38374d8 
Signed-off-by: emdneto <[email protected]>
@xrmx xrmx merged commit 829fcc5 into open-telemetry:main Mar 20, 2025
385 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@pmcollins pmcollins pmcollins approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emdneto @pmcollins @xrmx @lzchen