revert BaseException change #4494
Merged
+52
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emdneto <[email protected]>
xrmx
reviewed
Mar 18, 2025
lzchen
approved these changes
Mar 18, 2025
grihabor
reviewed
Mar 18, 2025
Signed-off-by: emdneto <[email protected]>
Co-authored-by: Gregory Borodin <[email protected]>
emdneto
commented
Mar 18, 2025
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
|
@emdneto Thanks for the PR! Do you have an estimated release date for this patch? Do you plan to make a patch release? |
xrmx
approved these changes
Mar 19, 2025
xrmx
reviewed
Mar 19, 2025
Signed-off-by: emdneto <[email protected]>
grihabor
approved these changes
Mar 19, 2025
emdneto
added a commit
to emdneto/opentelemetry-python
that referenced
this pull request
Mar 19, 2025
…4494) This reverts 1bd9ec6 since it's setting span as error for non error exceptions Signed-off-by: emdneto <[email protected]> Co-authored-by: Gregory Borodin <[email protected]>
xrmx
pushed a commit
that referenced
this pull request
Mar 20, 2025
…use_span (#4494) (#4495) * api: revert catching BaseException in trace.use_span (#4494) This reverts 1bd9ec6 since it's setting span as error for non error exceptions Signed-off-by: emdneto <[email protected]> Co-authored-by: Gregory Borodin <[email protected]> * fix workflows Signed-off-by: Emídio Neto <[email protected]> * skip gen workflows --------- Signed-off-by: emdneto <[email protected]> Signed-off-by: Emídio Neto <[email protected]> Co-authored-by: Gregory Borodin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the change from #4406
since it's setting span as error for non error exceptions
Fixes #4493
Fixes #4484