Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-opentracing-shim: add fixed setuptools version for testing #4503

Closed
wants to merge 2 commits into from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 24, 2025

Description

Use latest setuptools version < 78.0.0 because they removed support to parse the setup.cfg (description-file) used in opentracing.

Fixes #4502

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner March 24, 2025 16:36
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 24, 2025
Use latest version < 78.0.0 because they removed support to parse the
setup.cfg (description-file) used in opentracing.
@xrmx xrmx force-pushed the fix-opentracing-ci branch from df0a21d to 99bcf43 Compare March 24, 2025 16:42
@xrmx xrmx changed the title opentelemetry-opentracing-shim: add fixed setuptools version in test requirements opentelemetry-opentracing-shim: add fixed setuptools version for testing Mar 24, 2025
@xrmx
Copy link
Contributor Author

xrmx commented Mar 24, 2025

Uhm this fails and also install_command = python -m pip install setuptools<78 && python -m pip install {opts} {packages} fail because it is rendered as python -m pip install 'setuptools<78' '&&' python -m pip install -r dev-requirements.txt -r /home/rm/src/opentelemetry-python/shim/opentelemetry-opentracing-shim/test-requirements.txt with && quoted

@xrmx xrmx closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentracing not installable anymore with latest setuptools
1 participant