feat: ActiveRecord instrumentation improvements #1738
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
40
to
41
| 'db.active_record.async' => payload[:async] == true, | ||
| 'db.active_record.cached' => payload[:cached] == true |
There was a problem hiding this comment.
Thoughts about making this rails.active_record.* for consistency with the semconv pattern of not putting product specific attributes in the domain ie db namespace.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback.
I wasn't sure what direction to head since there isn't any semconv guidance for ORM of database abstraction libraries.
Namespacing under rails works for me
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.