chore: Add component owners workflow, documentation #1771
Conversation
Add the component owners workflow to automatically assign owners to pull requests when changes are proposed for their gem. This is blocked until we can make sure all component owners are members of the OpenTelemetry organization on GitHub and are added as members of the ruby-contrib-triagers team.
| the reviewer may seek additional reviews from people more familiar with the | ||
| change before merging a PR. | ||
|
|
||
| ## Component Ownership |
There was a problem hiding this comment.
This is largely copied from the guidelines in the opentelemetry-js-contrib CONTRIBUTING.md file.
kaylareopelle
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
requested review from
a team,
simi and
xuan-cao-swi
as code owners
| # https://help.github.com/en/articles/about-code-owners | ||
| # | ||
|
|
||
| * @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi |
There was a problem hiding this comment.
How do we fit into component owners?
What happens to the rest of the gems not listed under component owners e.g. propagators?
Shouldn't approvers and maintainers still be required for a final review?
There was a problem hiding this comment.
There isn't great documentation on this, so mostly I'm guessing.
The way I understand it, component owners will be able to approve a PR, but will not be able to merge a PR; so a maintainer will still have to take a look at it before it is fully accepted.
I believe the standard approvers and maintainers will have reviews requested in addition, but I'm really not certain. To keep our current setup (with each of our names listed), I may need to add our names to every directory. There isn't great documentation for this, but I can ask around. Looking at a js-contrib PR, it seems like the alias gets the request. I think the default setup will also assign component owners to the PR.
On a similar note, I'm not sure what happens to the rest of the gems that aren't listed. The JS Contrib file has empty arrays for directories without specific owners (ex).
There was a problem hiding this comment.
I think they still have CODEOWNERS in .github/ (e.g. * @open-telemetry/javascript-approvers)
There was a problem hiding this comment.
CNCF Slack Thread for these questions: https://cloud-native.slack.com/archives/C01NJ7V1KRC/p1761948733868689
Co-authored-by: Ariel Valentin <[email protected]>
This intends to continue our practice of having every maintainer and approver directly assigned to PRs
arielvalentin
left a comment
arielvalentin
left a comment
There was a problem hiding this comment.
Do you know if the component owners action fails if a new component is added but is not declared?
Also. I would like to have the instrumentation generator update the component owners file, that way when someone submits an instrumentation then they will declare themselves as component owners:
3 participants
Add the component owners workflow to automatically assign owners to pull requests when changes are proposed for their gem.
This is blocked until we can make sure all component owners are members of the OpenTelemetry organization on GitHub and are added as members of the ruby-contrib-triagers team.This shouldn't be a blocker, the JS team had names on the list that weren't members while still having the workflow setup