-
Notifications
You must be signed in to change notification settings - Fork 524
Docs for Metrics - add basic and advanced examples #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll start with a simple PR to kick-start 1 from the above, and iterate based on the feedbacks. |
@cijothomas this considered resolved now? |
Not yet. Will need another follow up to #1170 (it has desc. about the nest PRs.) |
One key thing missing today is: Tagging as good-first-issue, to see if anyone wants to enhance the example to show the above. |
Need to address the issue about using Views with OTLP Exporter as well. Its probably involves code change, but a temporary docs change could help as well : #1174 (comment) |
I'm interested in taking this on @cijothomas |
@mattbodd are you working on updating the docs? If not I'd like to work on this issue. TIA @cijothomas |
@Annosha feel free to send short PRs with doc improvements. There are WIP PRs like #2221 and #2220 that affect some docs, so short, focused PRs are recommended. Few things I suggest to make it super clear in docs (just an initial list from top of mind)
|
@Annosha Are you planning to work on this? |
#2946 can close this. |
Opening an issue to track adding docs for Metrics.
Proposing to add 2 examples to begin with:
The docs alone might not be sufficient, hence the proposal to have 2 examples. Happy to iterate based on feedback.
Note: It was discussed in today's SIG meeting as well, in the context of filling the spec compliant matrix. The examples will demonstrate most common use cases, and not every line item from the spec-compliance matrix.
Related issue : #914
The text was updated successfully, but these errors were encountered: