-
Notifications
You must be signed in to change notification settings - Fork 524
Add basic example showing how to use various metric instruments #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic example showing how to use various metric instruments #1062
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
=======================================
- Coverage 54.9% 54.9% -0.1%
=======================================
Files 151 151
Lines 18242 18245 +3
=======================================
Hits 10025 10025
- Misses 8217 8220 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reaonable to me. I understand we have too many examples at this point but with the new metrics example I think this one will be really benificial for users. We can probably clean up some other examples to reduce maintaince burdan
Agree. I'll be able to help with some cleanups/consolidation of the examples. |
@TommyCpp Could you merge please? |
Does your example of recording data to a histogram here use the |
It follows the spec, which states that the default is ExplicitBucket aggregation, using the default buckets. |
Towards #1060
Changes
Adds a example which showcases the usage of various instruments. The stdout exporter is used to display metrics.
There'll be a separate PR which shows common customizations, like changing temporality, using views, changing interval etc.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes