refactor: PushMetricExporter hide implementation for ResourceMetrics #2957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed
PushMetricExporer::export
signature.fn export(&self, metrics: ResourceMetricsRef<'_>) -> ...
. It is very similar toLogExporter::export
, with one differences, it doesn't exposeiter()
method on items (metrics), but provide acollect
function which accepts a lambda function which receives a lending iterator as an argument.This design, although doesn't look very friendly from user perspective, allow to maximum flexibility on internal implementation side.
collect
function limits lock scope, while we iterate over internal implementation.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes