feat: Decouple prost from otlp json#3451
Draft
jay-dee7 wants to merge 3 commits into
Draft
Conversation
Signed-off-by: jay-dee7 <me@jsdp.dev>
Signed-off-by: jay-dee7 <me@jsdp.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
=====================================
Coverage 83.2% 83.2%
=====================================
Files 128 128
Lines 25048 25048
=====================================
+ Hits 20859 20860 +1
+ Misses 4189 4188 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jay-dee7 <me@jsdp.dev>
0178656 to
032b343
Compare
|
Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience. It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3419
Design discussion issue (if applicable) #
Changes
Once
prosthas generated the stubs, we process them to include conditionalcfg-attrblocks so that OTLP/JSON-only implementation doesn't pull-in prost, properly respecting the defined cargo feature-set.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes