Implement scope_info_enabled#3503
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 130 130
Lines 27276 27284 +8
=======================================
- Hits 22609 22608 -1
- Misses 4667 4676 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| without_counter_suffixes: bool, | ||
| namespace: Option<String>, | ||
| disable_scope_info: bool, | ||
| scope_info_enabled: bool, |
| pub fn without_scope_info(mut self) -> Self { | ||
| self.disable_scope_info = true; | ||
| self.scope_info_enabled = false; | ||
| self | ||
| } |
There was a problem hiding this comment.
I kept the function just for backwards compatibility, but happy to remove it it isn't needed
| once_cell = { workspace = true } | ||
| opentelemetry = { workspace = true, features = ["metrics", "internal-logs"] } | ||
| opentelemetry_sdk = { workspace = true, features = ["metrics", "experimental_metrics_custom_reader"] } | ||
| opentelemetry_sdk = { workspace = true, features = ["metrics", "experimental_metrics_custom_reader", "spec_unstable_metrics_views"] } |
There was a problem hiding this comment.
I honestly don't understand why the LLM decided to add this here lol. I tried doing some research, but it seems way beyond my Rust knowledge
|
Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience. It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open. |
|
not stale, just waiting for reviews |
2 participants
Related to #3474, but entirely focused on the implementation of Instrumentation Scope.
Here I'm doing quite a few things:
otel_scope_infometric, which was removed from the spec long ago.without_scope_infotoscope_info_enabled, following the latest discussions we had at Prometheus exporter: Stabilize config optionscope_info_enabledopentelemetry-specification#5056Disclosure: Although I've done Rust before, I'm not great at it. I do rely on LLMs to write most of the code.
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes