Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics requirement levels to semconv repo #3956

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Mar 22, 2024

Follow up from open-telemetry/semantic-conventions#822

Changes

Changes the page for metric requirements levels to the Semantic conventions repo (or better, the Website).

CC @lmolkova

@joaopgrassi joaopgrassi requested review from a team March 22, 2024 16:40
@joaopgrassi
Copy link
Member Author

@chalin sorry for the ping, but want to make sure I did this correct for redirects on the website.

@joaopgrassi joaopgrassi changed the title Move metrics requirement levels moved to semconv repo Move metrics requirement levels to semconv repo Mar 22, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaopgrassi - no worries, ping is the best way to get my attention.

Your redirect entry looks good 👍🏻

@joaopgrassi
Copy link
Member Author

@chalin great! I guess then we need to generate the semconv pages in the website first, and only we can merge this, right? Do you know when we can do that?

@chalin
Copy link
Contributor

chalin commented Mar 27, 2024

@chalin great! I guess then we need to generate the semconv pages in the website first, and only we can merge this, right?

Right, that would be the best approach.

Do you know when we can do that?

@open-telemetry/specs-semconv-approvers would be in the best position to answer when the next release of the semconv will be.

@joaopgrassi
Copy link
Member Author

Ah we are planning to make a release soon, so all good. I will let you know then! Thanks

@joaopgrassi
Copy link
Member Author

@chalin
Copy link
Contributor

chalin commented Apr 4, 2024

@joaopgrassi - a major snow storm knocked out power since last night. I'll integrate the new semconv as soon as power & internet are fully back (my cell data service only came back online recently). Note that there's an invalid URL hash reported by the link checker which is preventing me from accepting the semconv update as is: for details, see open-telemetry/opentelemetry.io#4253 (review).

@joaopgrassi
Copy link
Member Author

@chalin no rush! Stay safe!

@chalin
Copy link
Contributor

chalin commented Apr 5, 2024

@joaopgrassi - PR open-telemetry/opentelemetry.io#4253 has been fixed and merged.

@joaopgrassi
Copy link
Member Author

@carlosalberto can you please merge? The website has been updated with the new semconv release. We are all good now!

@reyang reyang merged commit 3c2eaae into open-telemetry:main Apr 5, 2024
7 checks passed
@joaopgrassi joaopgrassi deleted the metrics-requirement-level-to-semconv branch April 7, 2024 14:51
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants