-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Triage Process] Allow SIG maintainers to express their requirements #4229
base: main
Are you sure you want to change the base?
[Triage Process] Allow SIG maintainers to express their requirements #4229
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that having a single maintainer-request
label could be good enough. The TC can prioritize the issue based on their judgement. Different maintelainers may also have different opinions on what is a blocker and what is not.
I don't have strong preference between the two proposals. When I think about the process, I can see the following cases which we might need to consider:
I understand that defining process is very hard. Nobody likes complicated process, but a big/complex project cannot succeed with clear/good process. THANK YOU for helping us to improve the process/efficiency @svrnm! |
I prefer small incremental changes in processes when these are not totally wrong (and need be rebuild from ground 😉) Thus proposing just one label. It will be easier also for maintainers to use as they won't need to think which label to select. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Will follow up as soon as possible! |
Co-authored-by: Reiley Yang <[email protected]>
Signed-off-by: svrnm <[email protected]>
20cef8e addresses the feedback provided:
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Can someone take a look at the recent changes I made? |
Co-authored-by: Reiley Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm supportive of trying this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board to try that out. I think there's some unideal fallout due to how github works, but we can figure out how to work around that.
I resolved the still open conversations since they were all outdated. |
Since #3990 is merged now, this fixes #4083
Changes
This introduces what has been discussed in #4083: it adds words to the issue management document to define the
maintainer-blocked
andmaintainer-request
labels and the process on how they can be applied by SIG maintainers.CHANGELOG.md
file updated for non-trivial changes