-
Notifications
You must be signed in to change notification settings - Fork 932
[spec/profiles] initial commit #4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Florian Lehner <[email protected]>
svrnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, overall LGTM
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
felixge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @florianl 🙇
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
99a9509 to
93ccadc
Compare
|
LGTM assuming changelog will be updated. |
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Updated with 18d133b |
Signed-off-by: Florian Lehner <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
|
friendly ping for merge @tigrannajaryan |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
### Metrics - `AlignedHistogramBucketExemplarReservoir` SHOULD use a time-weighted algorithm. ([#4678](#4678)) ### Profiles - Document the profiles signal. ([#4685](#4685)) ### Common - Extend the set of attribute value types to support more complex data structures. ([#4651](#4651)) --------- Co-authored-by: Armin Ruech <[email protected]>
Changes
Start to document OTel Profiles.
Friendly ping @open-telemetry/profiling-approvers.
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changes