Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh refcache and fix broken external links into Java API #2954

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 30, 2023

@chalin chalin added the CI/infra CI & infrastructure label Jun 30, 2023
@chalin chalin requested review from a team June 30, 2023 11:57
Comment on lines -69 to +70
- [reactor.core.publisher.Mono](https://projectreactor.io/docs/core/3.1.0.RELEASE/api/reactor/core/publisher/Mono.html)
- [reactor.core.publisher.Flux](https://projectreactor.io/docs/core/3.1.0.RELEASE/api/reactor/core/publisher/Flux.html)
- [reactor.core.publisher.Mono](https://projectreactor.io/docs/core/release/api/reactor/core/publisher/Mono.html)
- [reactor.core.publisher.Flux](https://projectreactor.io/docs/core/release/api/reactor/core/publisher/Flux.html)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API URLs with 3.1.0.RELEASE resulted in 404s. @open-telemetry/java-approvers please confirm that you're ok with the use of release instead in the API path.

[OpenTelemetry in Practice Meetup Group](https://meetup.com/opentelemetry-in-practice-meetup-group)
[OpenTelemetry in Practice Meetup Group](https://www.meetup.com/opentelemetry-in-practice-meetup-group/)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use canonical URL, otherwise the redirects seem to trip up the link checker sometimes.

@chalin
Copy link
Contributor Author

chalin commented Jun 30, 2023

@chalin chalin merged commit 893c3d6 into open-telemetry:main Jun 30, 2023
@chalin chalin deleted the chalin-im-refcache-2023-06-30 branch June 30, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants