Skip to content

Add concept page for resources #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 11, 2023

Adds a concept page explaining what resources are, what they are for and on a highlevel how they can be used.

It also adds a common intro text on resources that can now be used across languages (+special treatment for erlang:-) )

I also applied some weight changes to make them closer to what we have defined for language pages (see #2829)

@svrnm svrnm requested review from a team October 11, 2023 16:13
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but some suggestions in the main concept doc

@svrnm
Copy link
Member Author

svrnm commented Oct 13, 2023

Overall looks good, but some suggestions in the main concept doc

thanks, suggestions applied

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to appease the CI robots now

svrnm added 2 commits October 16, 2023 09:00
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
@svrnm svrnm merged commit a611ef2 into open-telemetry:main Oct 16, 2023
@svrnm svrnm deleted the add-resources-concept-page branch October 16, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants