Skip to content

Schemas: add /schemas/list page, and custom 404 for /schemas and missing subpages#3508

Closed
chalin wants to merge 20 commits intoopen-telemetry:mainfrom
chalin:chalin-im-schemas-list-2023-11-07
Closed

Schemas: add /schemas/list page, and custom 404 for /schemas and missing subpages#3508
chalin wants to merge 20 commits intoopen-telemetry:mainfrom
chalin:chalin-im-schemas-list-2023-11-07

Conversation

@chalin
Copy link
Copy Markdown
Contributor

@chalin chalin commented Nov 7, 2023

@svrnm @tigrannajaryan I think that this is most likely the solution that could meet all of our concerns, as summarized by @svrnm. Here is what this PR offers:

Previews

Redirect tests

Status tests

$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas | grep -E 'HTTP|-type|location' 
HTTP/2 404 
content-type: text/html; charset=UTF-8
$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas/ | grep -E 'HTTP|-type|location'
HTTP/2 404 
content-type: text/html; charset=UTF-8
$ curl -sI https://deploy-preview-3508--opentelemetry.netlify.app/schemas/list/ | grep -E 'HTTP|-type|location' 
HTTP/2 200 
content-type: text/html; charset=UTF-8

Screenshots

404 page:

image

List page:

image

@chalin chalin requested a review from a team November 7, 2023 12:13
@chalin chalin mentioned this pull request Nov 7, 2023
2 tasks
@chalin chalin force-pushed the chalin-im-schemas-list-2023-11-07 branch 5 times, most recently from 2b58499 to 925eac0 Compare November 7, 2023 14:45
@chalin chalin changed the title Schemas: add list page, and custom 404 Schemas: add /schemas/list page, and custom 404 for /schemas and missing subpages Nov 7, 2023
Comment thread content/en/schemas/list.md
Copy link
Copy Markdown
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor suggestions

@chalin chalin requested review from a team and svrnm November 7, 2023 16:04
@chalin chalin force-pushed the chalin-im-schemas-list-2023-11-07 branch from 7e70219 to f191c90 Compare November 7, 2023 20:10
@svrnm svrnm added the sig:spec label Nov 13, 2023
@chalin chalin force-pushed the chalin-im-schemas-list-2023-11-07 branch from f191c90 to 16b6215 Compare November 14, 2023 09:41
@chalin
Copy link
Copy Markdown
Contributor Author

chalin commented Nov 14, 2023

@chalin chalin closed this Nov 14, 2023
@chalin chalin deleted the chalin-im-schemas-list-2023-11-07 branch November 14, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/schemas is the top 404 Right nav formatting problem when page has no TOC

2 participants