-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schemas: add /schemas/list
page, and custom 404 for /schemas
and missing subpages
#3508
Closed
chalin
wants to merge
20
commits into
open-telemetry:main
from
chalin:chalin-im-schemas-list-2023-11-07
Closed
Schemas: add /schemas/list
page, and custom 404 for /schemas
and missing subpages
#3508
chalin
wants to merge
20
commits into
open-telemetry:main
from
chalin:chalin-im-schemas-list-2023-11-07
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b58499
to
925eac0
Compare
/schemas/list
page, and custom 404 for /schemas
and missing subpages
svrnm
reviewed
Nov 7, 2023
svrnm
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some minor suggestions
7e70219
to
f191c90
Compare
f191c90
to
16b6215
Compare
Closing in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svrnm @tigrannajaryan I think that this is most likely the solution that could meet all of our concerns, as summarized by @svrnm. Here is what this PR offers:
/schemas
is the top 404 #3468/schemas/list
page that lists the published schemas./schemas
that contains the link to the list pagePreviews
Redirect tests
Status tests
Screenshots
404 page:
List page: