Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing using instrumentation libraries pages: Python #4369

Merged
merged 13 commits into from
May 2, 2024
Merged

Add missing using instrumentation libraries pages: Python #4369

merged 13 commits into from
May 2, 2024

Conversation

theletterf
Copy link
Member

Part of #4319

@theletterf theletterf requested review from a team April 26, 2024 10:46
@theletterf theletterf self-assigned this Apr 26, 2024
@theletterf
Copy link
Member Author

@open-telemetry/python-maintainers Please have a look. Overall structure is based on other languages, though we might want to add further considerations on things like semver, stability, etc.

@theletterf
Copy link
Member Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8849315947

@opentelemetrybot
Copy link
Collaborator

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/8849315947 for details

svrnm
svrnm requested changes Apr 26, 2024
View reviewed changes
cartermp
cartermp reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback

@cartermp
Copy link
Contributor

/fix:recache

@theletterf theletterf requested a review from svrnm April 28, 2024 16:10
@theletterf
Copy link
Member Author

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8868831626

@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Apr 28, 2024
@cartermp
Copy link
Contributor

@open-telemetry/python-approvers PTAL!

@theletterf theletterf requested review from xrmx and cartermp April 29, 2024 14:18
xrmx
xrmx approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but better wait from a Python SIG maintainer review

@theletterf
Copy link
Member Author

@lzchen PTAL

@theletterf
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8891414384

@chalin chalin force-pushed the 4319-meta-add-missing-using-instrumentation-libraries-pages-python branch from 97e2697 to 8efbbe6 Compare May 1, 2024 22:04
@theletterf
Copy link
Member Author

I think this one is good to go?

@svrnm svrnm merged commit d8844b5 into main May 2, 2024
17 checks passed
@svrnm svrnm deleted the 4319-meta-add-missing-using-instrumentation-libraries-pages-python branch May 2, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen left review comments

@xrmx xrmx xrmx approved these changes

@svrnm svrnm svrnm approved these changes

@cartermp cartermp Awaiting requested review from cartermp

Assignees

@theletterf theletterf

Labels
sig:python sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theletterf @opentelemetrybot @cartermp @xrmx @svrnm @lzchen