-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-boxed entries for the banner #4429
Conversation
…etry.io into time-boxed-banner
…etry.io into time-boxed-banner
It should be good. Here is a test I did with some debug: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like it works as expected, a few additional suggestions
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Yes, we might consider that sometimes we want to have more than 2, but this should be the default, otherwise this is in a really good shape, thx. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9046659360 |
fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/9046659360 for details |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9046740195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @ricardoamaro. See inline comments.
@svrnm - even after the suggested edits are addressed, this should be put on hold until we get an answer to #2402 (comment).
Co-authored-by: Patrice Chalin <[email protected]>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9086168074 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the suggested changes. LGTM
hey @ricardoamaro, apologies for taking that long, but when we started this I didn't anticipate that we would make a move towards internationalization & localization, which as @chalin mentioned in #2402 (comment) requires a different approach eventually. We want to appreciate your contribution, so I am going to merge the PR in, but I wanted to be fully transparent, that this change will see some major rework again. Thank you! |
Dynamically manage and display banner entries as suggested in #4380
banners.md
file to sort the entries by the end dates (.to:)