Skip to content

Update Java SDK Configuration page #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

jaydeluca
Copy link
Member

Closes #4578

Follows up on additional feedback from #4377

  • Describe properties in a way that makes it clear that they can be used outside the otel java agent
  • Update system property -> env var example to use a relevant property
  • Provide context on what the autoconfigure module is and add links
  • Move text about configuration priority inside the signal configuration alert.
  • Update text about reusable_data to incorporate all signals
  • Fix footnote links
  • Remove section about configuring service name
  • Move resource section above exporters
  • Update language around customizing the sdk, resource names, and ResourceProvider
  • Add new column in table with context for where each artifact lives (tracecontext etc)
  • Mention artifact coordinates in each place where we describe configuration that requires a particular artifact to be included to work

@jaydeluca jaydeluca requested review from a team June 2, 2024 15:13
@jaydeluca
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9340120977

@github-actions github-actions bot requested review from a team and atoulme and removed request for a team June 2, 2024 17:45
@cartermp cartermp removed request for a team June 2, 2024 18:43
@cartermp cartermp removed request for a team and atoulme June 2, 2024 18:43
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some basic copy-edits -- largely looks good from a narrative/structuring standpoint.

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Just some nits.

@svrnm
Copy link
Member

svrnm commented Jun 3, 2024

@open-telemetry/java-approvers @open-telemetry/java-instrumentation-approvers PTAL

@cartermp cartermp added sig-approval-missing Co-owning SIG didn't provide an approval labels Jun 4, 2024
@cartermp cartermp removed the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 5, 2024
@cartermp
Copy link
Contributor

cartermp commented Jun 5, 2024

Thank you @jaydeluca

@cartermp cartermp merged commit d0b5858 into open-telemetry:main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to the Java SDK Configuration page
6 participants