Refactor java SDK and configuration#4966
Conversation
|
Corresponding PR with supporting code snippets: open-telemetry/opentelemetry-java-examples#455 |
| the SDK. For an exhaustive set of the available configuration APIs, consult the | ||
| code. | ||
|
|
||
| ## Zero-code SDK autoconfigure |
There was a problem hiding this comment.
the term zero-code already has a meaning: https://opentelemetry.io/docs/concepts/instrumentation/zero-code/
maybe "declarative"?
There was a problem hiding this comment.
I'm trying to rebrand file configuration as "declarative configuration" here: open-telemetry/opentelemetry-specification#4128
Since SDK autoconfigure combines environment variable / system property configuration AND declarative configuration in one module, calling it "declarative configuration" is probably not a great name.
Maybe just "SDK autoconfigure"? Also open to other ideas..
theletterf
left a comment
There was a problem hiding this comment.
Fantastic work! Leaving a first round of suggestions.
|
Thanks for the reviews @theletterf, @zeitlinger! |
jaydeluca
left a comment
There was a problem hiding this comment.
huge improvement, bravo! 👏
Left some ideas and suggestions for consideration.
|
Finally, I found some time to take a look, but I see already that @theletterf , @jaydeluca and @zeitlinger are providing reviews and great feedback! Awesome work, looking forward to see this land. |
fe84b47 to
a53743d
Compare
| otel: 1.42.1 | ||
| contrib: 1.38.0 | ||
| semconv: 1.27.0 |
There was a problem hiding this comment.
@open-telemetry/docs-maintainers - a reminder that an en PR shouldn't be updating non-en pages.
There was a problem hiding this comment.
This PR doesn't add a redirect rule for content/en/docs/languages/java/exporters.md, which it deletes, resulting in one of the top 404s. Let me create an issue to track a fix.
There was a problem hiding this comment.
This is the first PR in what will be a multi-step reworking of the Java docs, as discussed in #4853 and the related doc.
Disclaimer: Refactoring docs iteratively is difficult because its hard to know where to stop. Docs develop organically over time and end with lots of interlinking and little warnings which get in the way of refactoring. For this PR, the scope I targeted was the "SDK", but this leaked into "SDK configuration" because the two are so tightly connected. It also leaked into the "Instrumentation" page which often talks about the SDK through conflated responsibilities. It also leaked into the standalone "Resources", "Exporters", and "Samplers" pages since these are SDK concepts.
What does this PR do?
There is lot of content in this PR, but the principles are simple and scalable. The quantity of content reflects the essential complexity of the project, and is required in order for completeness. I recommend reviewing by looking at the rendered website.
I have future PRs planned for:
cc @open-telemetry/java-approvers, @open-telemetry/java-instrumentation-approvers
Preview: https://deploy-preview-4966--opentelemetry.netlify.app/docs/languages/java/