-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog cncf.io repost by OTel CI/CD SIG #5718
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first quick review, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style suggestions and copy edits. Thanks!
@horovits since you provided that feedback across multiple comments by @tiffany76, I'll address it here:
I disagree with that. We (SIG Comms) allow the re-publication of blog posts from other sources, acknowledging that there are reasons making this necessary, but we will not bend on our standards of quality, this includes that we provide rich copy editing feedback to blog authors. We are very lucky that we have experienced technical writers like @tiffany76 in our SIG who spend time and effort to ensure that. Please reciprocate with spending your time and effort to either accept the feedback or engage in a meaningful discussion. |
@horovits please take a look at the feedback provided. Thanks |
per @svrnm editorial review open-telemetry#5718 (comment)
per @svrnm editorial review open-telemetry#5718 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we've rolled into 2025, we'll need to decide this this is meant to be cross-posted under a 2024 or 2025 date.
Cf.:
@horovits are you still interested in publishing this blog post, if so please take a look at the review, if not, let us know and we close this PR |
@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion. |
There are a few pending remarks: https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868537275 Some of them got outdated due to other changes, but the first few are still unresolved, please take a look, accept them or comment if you think otherwise. Most of them are linguistic, so we should be able to resolve them quickly. |
@svrnm Thanks for flagging, pardon my oversight with the outdated ones, indeed no blocker, committing to resolve
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should help with the spellchecker.
Co-authored-by: Severin Neumann <[email protected]> Co-authored-by: Tiffany Hrabusa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Will leave it to @chalin and @tiffany76 for final review!
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13502162950 |
IMPORTANT: (RE-)RUN
|
Trying to kick start the GH checks. Doesn't seem to be working, so I'll do it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and all checks are green ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Oops, nope, just noticed that the post is in the wrong year folder. I'll try to change it.
- Also, we need to link to the canonical post. I'll change that too. ✔️ @chalin
@horovits - because the PR branch name is |
Oh, never mind, it seems that I found a way to do it! \o/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the path has been fixed, see https://deploy-preview-5718--opentelemetry.netlify.app/blog/2025/otel-cicd-sig/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey |
This is a post by SIG CI/CD Observability, which was posted on cncf.io towards KubeCon NA '24.
Submitting in accordance with the approved issue 5546: #5546
Note: due to lack of support in the OTel blog in embedding social media (thanks @svrnm for the clarification), those embeds from the original CNCF blog have been omitted.
If there's a way to support those, please let me know and I'd be happy to amend.
Preview:
https://deploy-preview-5718--opentelemetry.netlify.app/blog/2024/otel-cicd-sig/