Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog cncf.io repost by OTel CI/CD SIG #5718

Merged
merged 30 commits into from
Feb 24, 2025
Merged

Conversation

horovits
Copy link
Contributor

@horovits horovits commented Dec 3, 2024

This is a post by SIG CI/CD Observability, which was posted on cncf.io towards KubeCon NA '24.
Submitting in accordance with the approved issue 5546: #5546

Note: due to lack of support in the OTel blog in embedding social media (thanks @svrnm for the clarification), those embeds from the original CNCF blog have been omitted.
If there's a way to support those, please let me know and I'd be happy to amend.


Preview:

@horovits horovits requested a review from a team as a code owner December 3, 2024 09:47
Copy link

linux-foundation-easycla bot commented Dec 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first quick review, PTAL

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestions and copy edits. Thanks!

@opentelemetrybot opentelemetrybot requested a review from a team December 4, 2024 10:11
@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

@horovits since you provided that feedback across multiple comments by @tiffany76, I'll address it here:

this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.

I disagree with that. We (SIG Comms) allow the re-publication of blog posts from other sources, acknowledging that there are reasons making this necessary, but we will not bend on our standards of quality, this includes that we provide rich copy editing feedback to blog authors. We are very lucky that we have experienced technical writers like @tiffany76 in our SIG who spend time and effort to ensure that. Please reciprocate with spending your time and effort to either accept the feedback or engage in a meaningful discussion.

@svrnm
Copy link
Member

svrnm commented Dec 18, 2024

@horovits please take a look at the feedback provided. Thanks

horovits added a commit to horovits/opentelemetry.io that referenced this pull request Dec 23, 2024
chalin pushed a commit to horovits/opentelemetry.io that referenced this pull request Jan 4, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've rolled into 2025, we'll need to decide this this is meant to be cross-posted under a 2024 or 2025 date.

Cf.:

@svrnm
Copy link
Member

svrnm commented Jan 20, 2025

@horovits are you still interested in publishing this blog post, if so please take a look at the review, if not, let us know and we close this PR

@horovits
Copy link
Contributor Author

@horovits are you still interested in publishing this blog post, if so please take a look at the review, if not, let us know and we close this PR

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

@svrnm
Copy link
Member

svrnm commented Jan 29, 2025

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

There are a few pending remarks:

https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868537275
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868546418
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868553787
https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868554342
#5718 (comment)
#5718 (comment)
#5718 (comment)

Some of them got outdated due to other changes, but the first few are still unresolved, please take a look, accept them or comment if you think otherwise. Most of them are linguistic, so we should be able to resolve them quickly.

@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 19:19
@horovits
Copy link
Contributor Author

@svrnm Thanks for flagging, pardon my oversight with the outdated ones, indeed no blocker, committing to resolve

@svrnm all the outstanding review items have been resolved before the turn of the year. The blog post is ready to publish on my part. As to adjusting the year, I'm fine with posting it under 2024 or under 2025, I'll leave it to your discretion.

There are a few pending remarks:

https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868537275 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868546418 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868553787 https://github.com/open-telemetry/opentelemetry.io/pull/5718/files#r1868554342 #5718 (comment) #5718 (comment) #5718 (comment)

Some of them got outdated due to other changes, but the first few are still unresolved, please take a look, accept them or comment if you think otherwise. Most of them are linguistic, so we should be able to resolve them quickly.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help with the spellchecker.

@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 21:55
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 22:01
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Will leave it to @chalin and @tiffany76 for final review!

@chalin
Copy link
Contributor

chalin commented Feb 21, 2025

Thanks @svrnm.

@horovits - waiting on the final suggestions to be addressed before my final approval. Btw, adding the links to users would be nice to have but not essential. Let's get this post published! :)

@opentelemetrybot opentelemetrybot requested a review from a team February 23, 2025 07:12
@chalin
Copy link
Contributor

chalin commented Feb 24, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13502162950

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin chalin closed this Feb 24, 2025
@chalin chalin reopened this Feb 24, 2025
@chalin
Copy link
Contributor

chalin commented Feb 24, 2025

Trying to kick start the GH checks. Doesn't seem to be working, so I'll do it locally.

@opentelemetrybot opentelemetrybot requested a review from a team February 24, 2025 16:44
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and all checks are green ✨

@opentelemetrybot opentelemetrybot requested a review from a team February 24, 2025 17:36
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Oops, nope, just noticed that the post is in the wrong year folder. I'll try to change it.
  • Also, we need to link to the canonical post. I'll change that too. ✔️ @chalin

@opentelemetrybot opentelemetrybot requested a review from a team February 24, 2025 17:43
@chalin
Copy link
Contributor

chalin commented Feb 24, 2025

@horovits - because the PR branch name is main, I can't move the post into the 2025 folder. You'll have to do it.

@chalin
Copy link
Contributor

chalin commented Feb 24, 2025

@horovits - because the PR branch name is main, I can't move the post into the 2025 folder. You'll have to do it.

Oh, never mind, it seems that I found a way to do it! \o/

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiffany76 tiffany76 added this pull request to the merge queue Feb 24, 2025
Merged via the queue into open-telemetry:main with commit 0a9040b Feb 24, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants