Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal telemetry config options for OTLP export #5986

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

@meswapnilk meswapnilk requested a review from a team as a code owner January 20, 2025 04:19
@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team January 20, 2025 04:19
@svrnm
Copy link
Member

svrnm commented Jan 20, 2025

@codeboten please take a look if this is what you were looking for in #5721

@svrnm svrnm requested a review from codeboten January 20, 2025 08:01
@tiffany76
Copy link
Contributor

@codeboten ping :)

@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 04:27
@theletterf
Copy link
Member

@open-telemetry/collector-approvers Could you have a look, please? Thanks!

Comment on lines +184 to +185
The Collector can be configured to push its own telemetry to an
[OTLP receiver](https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, could we link to docs page, maybe docs/collector/configuration/#receivers. That page links out to the repo's receiver folder.

@theletterf @tiffany76 @open-telemetry/docs-approvers WDYT?

Copy link
Contributor

@tiffany76 tiffany76 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but I think @jade-guiton-dd's comment below is worth addressing first. This PR's content was purposely removed from the page in a previous PR, and there's been no call to add it back.

Comment on lines +233 to +241
When self-monitoring, the Collector collects its own telemetry and sends it to
the desired backend for analysis. This can be a risky practice. If the Collector
is underperforming, its self-monitoring capability could be impacted. As a
result, the self-monitored telemetry might not reach the backend in time for
critical analysis.

Moreover, sending internal telemetry through the Collector's own pipelines can
create a continuous loop of spans, metric points, or logs, putting undue strain
on the Collector's performance. This setup should not be used in production.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When self-monitoring, the Collector collects its own telemetry and sends it to
the desired backend for analysis. This can be a risky practice. If the Collector
is underperforming, its self-monitoring capability could be impacted. As a
result, the self-monitored telemetry might not reach the backend in time for
critical analysis.
Moreover, sending internal telemetry through the Collector's own pipelines can
create a continuous loop of spans, metric points, or logs, putting undue strain
on the Collector's performance. This setup should not be used in production.
Self-monitoring risks impacting the Collector's performance: routing internal
telemetry through the Collector's pipelines can create feedback loops, further
stressing the system. Avoid self-monitoring in production.

@jade-guiton-dd
Copy link
Contributor

This PR seems to add back, verbatim, the section about self-monitoring that was intentionally removed in #5749 to avoid suggesting an unstable setup to users. Do we have a rationale for adding it back?

And I don't think the tracking issue is related to this: reading through its history in #5702, it sounds like it was originally about updating the table of configuration options under "Configure internal logs", and adding something similar for traces and metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

collector: internal telemetry page should document config options for OTLP
6 participants