Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [es] Create docs/contributing/issues.md #6088

Merged
merged 23 commits into from
Feb 13, 2025

Conversation

didiViking
Copy link
Contributor

Related issue: #5205

@didiViking didiViking requested a review from a team as a code owner January 27, 2025 15:44
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team January 27, 2025 15:44
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution. See inline comments for guidance.

default_lang_commit: 30783526402b69a3ac44eeb0f6cf066732f0bdca
default_lang_commit: 8256a7512f0f5e677963e082d257edc443940565
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By updating the commit hash you are confirming that no changes since 3078352 affect the content of this file. Is that true? (I don't think so.) If not, revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.

I will try to clarify, the official documentation is here https://opentelemetry.io/docs/contributing/localization/

Copy link
Contributor Author

@didiViking didiViking Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[@krol3] Thanks, I took a look and this is the last commit based on the docs:
8256a75.
Screenshot 2025-01-29 at 09 24 58

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 Can this be marked as solved?

Copy link
Contributor

@chalin chalin Feb 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didiViking, generally speaking, don't mark a thread as resolved if you didn't create the thread; unless it is very clear that the issue is resolved, which it isn't in this case.

To learn how to manage default_lang_commit fields, read Keeping track of localized-page drift. Let me know if you know if you have any questions after reading that.

In particular you should be using commands like the following to help you figure out the es page drift:

  • npm run check:i18n -- content/es/docs/contributing/_index.md
  • npm run check:i18n -- -d content/es/docs/contributing/_index.md to see the diff details.

I've marked this PR as blocked until the default_lang_commit updates are undone or properly addressed. Thanks.

@opentelemetrybot opentelemetrybot requested review from a team January 27, 2025 17:24
Copy link
Contributor

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didiViking excelent work! thanks for your contribution

@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team January 29, 2025 15:44
@didiViking didiViking requested a review from krol3 January 29, 2025 15:46
@opentelemetrybot opentelemetrybot requested a review from a team January 29, 2025 15:46
@chalin chalin added the blocked label Feb 2, 2025
@chalin
Copy link
Contributor

chalin commented Feb 2, 2025

@krol3 and @open-telemetry/docs-es-approvers - as mentioned in https://cloud-native.slack.com/archives/C076RUAGP37/p1738265105433829

All: a quick reminder to tag your PRs with the label docs-approval-missing when you have completed your locale-specific review and are awaiting final docs-maintainers approval.

Thanks.

@chalin chalin changed the title feat: [es] Create docs/contributing/asuntos.md feat: [es] Create docs/contributing/issues.md Feb 3, 2025
@chalin chalin force-pushed the docs/contributing branch from c593266 to f22c932 Compare February 6, 2025 11:57
@opentelemetrybot opentelemetrybot requested a review from a team February 11, 2025 11:06
@chalin
Copy link
Contributor

chalin commented Feb 11, 2025

Thanks for your review @mx-psi. Is this ready for a docs-maintainers review? If so, please add the docs-approval-missing label.

@didiViking - the spell-checks are failing, can you please address them? Thanks!

@mx-psi mx-psi added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 11, 2025
@mx-psi
Copy link
Member

mx-psi commented Feb 11, 2025

@chalin Done!

@didiViking
Copy link
Contributor Author

@chalin @mx-psi Tbh I ran the fix all command on my local branch then I pushed it again. The spell check complains about 2 correct words in Spanish. Not sure what to do next.

@chalin
Copy link
Contributor

chalin commented Feb 11, 2025

@chalin @mx-psi Tbh I ran the fix all command on my local branch then I pushed it again. The spell check complains about 2 correct words in Spanish. Not sure what to do next.

Thanks for looking into this @didiViking.

@theletterf @mx-psi or any other @open-telemetry/docs-es-approvers - I need you to confirm the translations and the spelling. See https://github.com/open-telemetry/opentelemetry.io/pull/6088/files for the spelling issues in context.

If you consider the translation correct, and the words correct, then add the words to our local word file (https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell/es-palabras.txt), or consider submitting a PR over https://github.com/streetsidesoftware/cspell-dicts/blob/main/dictionaries/es_ES/src/additional_words.txt.

@mx-psi
Copy link
Member

mx-psi commented Feb 11, 2025

Redireccionar is in the DLE: https://dle.rae.es/redireccionar and the suggested alternatives from the spellchecker are all nonsensical.

"Prellenada" sounds correct, it won't show up on the DLE because of the prefix, but thinking about it further "prerrellenada" sounds better to me and it is confirmed correct by the DLE account on X here

@chalin chalin removed blocked docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer labels Feb 11, 2025
@chalin
Copy link
Contributor

chalin commented Feb 11, 2025

Thanks @mx-psi. I've removed the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label. Please add it back once you are satisfied with the edits, and all GH checks are passing. 🙌🏻 Getting closer to merging @didiViking 👍🏻.

@didiViking
Copy link
Contributor Author

didiViking commented Feb 12, 2025

@mx-psi The spellcheck still fails:
Unknown word (redireccionar) Suggestions: (redirecionar, redireciona, redirecionai, redirecionam, redirecionas)
SPELLING check: content/es/docs/contributing/issues.md#L59
Unknown word (prerrellenada) Suggestions: (prerellenadd, prerellenbad, prerellenday, prerellenhad, prerellenpad)

How can we solve this? Apparently it's the only blocker to this PR.

@mx-psi
Copy link
Member

mx-psi commented Feb 12, 2025

@didiViking My understanding is that you need to add these to https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell/es-palabras.txt

Comment on lines +30 to +33
<!-- prettier-ignore -->
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan contribuido a la organización [OpenTelemetry
> organization][org], a menos que sean parte de un proceso de tutoria o onboarding.
{.mt-3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- prettier-ignore -->
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan contribuido a la organización [OpenTelemetry
> organization][org], a menos que sean parte de un proceso de tutoria o onboarding.
{.mt-3}
<!-- prettier-ignore -->
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan
> contribuido a la organización [OpenTelemetry organization][org], a menos
> que sean parte de un proceso de tutoria o onboarding.
{.mt-3}

Copy link
Contributor

@chalin chalin Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didiViking - it seems that we both missed ensuring that this suggestion was applied. Please ensure that you address all suggestions for future PRs, thanks (I had assumed that it was done 🤷🏼‍♂️).

@chalin chalin requested a review from mx-psi February 12, 2025 15:19
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @mx-psi confirms that you're ok with the latest changes.

@didiViking
Copy link
Contributor Author

@mx-psi Thank you for the support for this PR. I'm unable to merge it due to this error.
Screenshot 2025-02-13 at 09 48 20

@chalin
Copy link
Contributor

chalin commented Feb 13, 2025

@mx-psi Thank you for the support for this PR. I'm unable to merge it due to this error. ...

Right, only maintainers can merge. I'm submitting this to the merge queue.

@chalin chalin added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit e9b4922 Feb 13, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

chalin added a commit to chalin/opentelemetry.io that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants