-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [es] Create docs/contributing/issues.md #6088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution. See inline comments for guidance.
default_lang_commit: 30783526402b69a3ac44eeb0f6cf066732f0bdca | ||
default_lang_commit: 8256a7512f0f5e677963e082d257edc443940565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By updating the commit hash you are confirming that no changes since 3078352 affect the content of this file. Is that true? (I don't think so.) If not, revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.
I will try to clarify, the official documentation is here https://opentelemetry.io/docs/contributing/localization/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 Can this be marked as solved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didiViking, generally speaking, don't mark a thread as resolved if you didn't create the thread; unless it is very clear that the issue is resolved, which it isn't in this case.
To learn how to manage default_lang_commit
fields, read Keeping track of localized-page drift. Let me know if you know if you have any questions after reading that.
In particular you should be using commands like the following to help you figure out the es
page drift:
npm run check:i18n -- content/es/docs/contributing/_index.md
npm run check:i18n -- -d content/es/docs/contributing/_index.md
to see the diff details.
I've marked this PR as blocked
until the default_lang_commit
updates are undone or properly addressed. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didiViking excelent work! thanks for your contribution
@krol3 and @open-telemetry/docs-es-approvers - as mentioned in https://cloud-native.slack.com/archives/C076RUAGP37/p1738265105433829
Thanks. |
Signed-off-by: Diana Todea <[email protected]>
Signed-off-by: Diana Todea <[email protected]>
Signed-off-by: Diana Todea <[email protected]>
Signed-off-by: Diana Todea <[email protected]>
Signed-off-by: Diana Todea <[email protected]>
ac8ba46
to
c593266
Compare
c593266
to
f22c932
Compare
Signed-off-by: Diana Todea <[email protected]>
f22c932
to
2161315
Compare
Signed-off-by: Diana Todea <[email protected]>
Signed-off-by: Diana Todea <[email protected]>
Thanks for your review @mx-psi. Is this ready for a docs-maintainers review? If so, please add the @didiViking - the spell-checks are failing, can you please address them? Thanks! |
Signed-off-by: Diana Todea <[email protected]>
@chalin Done! |
Thanks for looking into this @didiViking. @theletterf @mx-psi or any other @open-telemetry/docs-es-approvers - I need you to confirm the translations and the spelling. See https://github.com/open-telemetry/opentelemetry.io/pull/6088/files for the spelling issues in context. If you consider the translation correct, and the words correct, then add the words to our local word file (https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell/es-palabras.txt), or consider submitting a PR over https://github.com/streetsidesoftware/cspell-dicts/blob/main/dictionaries/es_ES/src/additional_words.txt. |
Redireccionar is in the DLE: https://dle.rae.es/redireccionar and the suggested alternatives from the spellchecker are all nonsensical. "Prellenada" sounds correct, it won't show up on the DLE because of the prefix, but thinking about it further "prerrellenada" sounds better to me and it is confirmed correct by the DLE account on X here |
Thanks @mx-psi. I've removed the
docs-approval-missing
|
Signed-off-by: Diana Todea <[email protected]>
@mx-psi The spellcheck still fails: How can we solve this? Apparently it's the only blocker to this PR. |
@didiViking My understanding is that you need to add these to https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell/es-palabras.txt |
Signed-off-by: Diana Todea <[email protected]>
<!-- prettier-ignore --> | ||
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan contribuido a la organización [OpenTelemetry | ||
> organization][org], a menos que sean parte de un proceso de tutoria o onboarding. | ||
{.mt-3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- prettier-ignore --> | |
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan contribuido a la organización [OpenTelemetry | |
> organization][org], a menos que sean parte de un proceso de tutoria o onboarding. | |
{.mt-3} | |
<!-- prettier-ignore --> | |
> **NOTA**: **_No_ asignamos propuestas** a aquellos que aún no hayan | |
> contribuido a la organización [OpenTelemetry organization][org], a menos | |
> que sean parte de un proceso de tutoria o onboarding. | |
{.mt-3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didiViking - it seems that we both missed ensuring that this suggestion was applied. Please ensure that you address all suggestions for future PRs, thanks (I had assumed that it was done 🤷🏼♂️).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once @mx-psi confirms that you're ok with the latest changes.
@mx-psi Thank you for the support for this PR. I'm unable to merge it due to this error. |
Right, only maintainers can merge. I'm submitting this to the merge queue. |
Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey |
Related issue: #5205