Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] translate contributing/style-guide into ja #6255

Merged
merged 6 commits into from
Feb 13, 2025
Merged

[ja] translate contributing/style-guide into ja #6255

merged 6 commits into from
Feb 13, 2025
+104 −0

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Feb 9, 2025 •
edited
Loading

translated contributing/style-guide page into ja

@opentelemetrybot opentelemetrybot requested review from a team February 9, 2025 07:17
@Msksgm Msksgm changed the title docs: translated contributing/style-guide into ja [ja] translate contributing/style-guide into ja Feb 9, 2025
@Msksgm Msksgm marked this pull request as ready for review February 9, 2025 07:20
@Msksgm Msksgm requested a review from a team as a code owner February 9, 2025 07:20
ymotongpoo
ymotongpoo requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I left some comments for approval.

content/ja/docs/contributing/style-guide.md Outdated

{{% alert title="Note" color="primary" %}}

スタイガイドの多くの要件されることは、自動化で強制されています。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スタイルガイド のtypo

Copy link
Contributor Author

@Msksgm Msksgm Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

40f3c84

content/ja/docs/contributing/style-guide.md Outdated
スタイガイドの多くの要件されることは、自動化で強制されています。
[pull request](https://docs.github.com/en/get-started/learning-about-github/github-glossary#pull-request)(PR) を提出する前に、ローカルで `npm run fix:all` を実行して、変更をコミットしてください。

エラーまたは [failed PR checks](../pr-checks) に遭遇した場合、スタイガイドを読んで特定の一般的な問題を修正するのにできることを学んでください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

40f3c84

content/ja/docs/contributing/style-guide.md Outdated

OpenTelemetry 特有の用語や単語の一覧であり、サイト全体で一貫して利用されるべきもの。

- [OpenTelemetry](/docs/concepts/glossary/#opentelemetry) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and 訳し漏れ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my mistake. I fixed a bellow commit.

cb6bcca

content/ja/docs/contributing/style-guide.md Outdated

OpenTelemetry 特有の用語や単語の一覧であり、サイト全体で一貫して利用されるべきもの。

- [OpenTelemetry](/docs/concepts/glossary/#opentelemetry) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リンク先が日本語訳済みであれば、リンクテキストも訳してください

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

（glossaryのページは翻訳済みです）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

d272c46

content/ja/docs/contributing/style-guide.md Outdated
OpenTelemetry の用語と定義の完璧なリストには、[Glossary](/docs/concepts/glossary/) を参照してください。

ほかの CNCF プロジェクトやサードパーティツールなどの固有名詞は、適切に表記し、元の大文字・小文字の区別を正しく維持してください。
例えば、"postgre" のかわりに "PostgreSQL" と表記してください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

例えば→たとえば

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

5e377ae

content/ja/docs/contributing/style-guide.md Outdated

ほかの CNCF プロジェクトやサードパーティツールなどの固有名詞は、適切に表記し、元の大文字・小文字の区別を正しく維持してください。
例えば、"postgre" のかわりに "PostgreSQL" と表記してください。
全てのリストは、[`.textlintrc.yml`](https://github.com/open-telemetry/opentelemetry.io/blob/main/.textlintrc.yml) を確認してください。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全て→すべて

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed a bellow commit.

446a000

@Msksgm Msksgm force-pushed the ja/contributing/style-guide branch from 784e4b9 to d272c46 Compare February 10, 2025 07:42
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 07:42
@Msksgm
Copy link
Contributor Author

Msksgm commented Feb 10, 2025

@ymotongpoo

Thank you for your review.
I fixed it. Please review it again.

@Msksgm Msksgm mentioned this pull request Feb 10, 2025
Merged
@ymotongpoo ymotongpoo force-pushed the ja/contributing/style-guide branch from d272c46 to f553523 Compare February 13, 2025 06:05
@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 13, 2025
ymotongpoo
ymotongpoo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit 76f59e2 Feb 13, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@Msksgm Msksgm deleted the ja/contributing/style-guide branch February 13, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymotongpoo ymotongpoo ymotongpoo approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Msksgm @opentelemetrybot @ymotongpoo @chalin