Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] apply base new directory structure of /docs/concepts/instrumentation/zero-code.md #6259

Conversation

tk3fftk
Copy link
Contributor

@tk3fftk tk3fftk commented Feb 9, 2025

ドキュメント/概念/計装/Zero-code page has been translated but the directory has been updated so Japanese pages was not show.

This pull request includes changes to the Japanese documentation for Zero Code instrumentation. The changes involve renaming the file, updating a commit reference, and adding an image to enhance the content.

Documentation updates:

This is my first Pull Request to this repo. Please let me know anything if needed to action 🙇

@tk3fftk tk3fftk requested a review from a team as a code owner February 9, 2025 14:38
@opentelemetrybot opentelemetrybot requested review from a team February 9, 2025 14:38
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Could you check if there are any Japanese translation pages that refer to old path of this page? If yes, can you fix those links as well?

@opentelemetrybot opentelemetrybot requested a review from a team February 11, 2025 00:21
@tk3fftk
Copy link
Contributor Author

tk3fftk commented Feb 11, 2025

@ymotongpoo Thank you for your review🙏
I checked and old paths are looks already replaced 👀

$ grep -r "instrumentation/zero-code" ./content/ja
./content/ja/docs/getting-started/ops.md:- [アプリケーションのコードに触れることなく計装する方法](../../concepts/instrumentation/zero-code/)
./content/ja/docs/concepts/components.md:詳細は、[ゼロコード計装](/docs/concepts/instrumentation/zero-code/)のページを参照してください。
./content/ja/docs/concepts/instrumentation/_index.md:2. [ゼロコードソリューション](/docs/concepts/instrumentation/zero-code/)

@tk3fftk tk3fftk requested a review from ymotongpoo February 11, 2025 00:30
@ymotongpoo ymotongpoo force-pushed the ja/refactor_concepts/instrumentation/zero-code.md branch from 116bedb to fb1b777 Compare February 13, 2025 05:55
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 13, 2025
@chalin chalin added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit f59a304 Feb 13, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@tk3fftk tk3fftk deleted the ja/refactor_concepts/instrumentation/zero-code.md branch February 14, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Development

Successfully merging this pull request may close these issues.

4 participants