Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Localize content/pt/ecosystem/registry #6263

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[pt] Localize content/pt/ecosystem/registry #6263

merged 2 commits into from
Feb 14, 2025

Conversation

vitorvasc
Copy link
Member

@vitorvasc vitorvasc commented Feb 10, 2025 •
edited
Loading

Tracked on #6242

Localizes the content (Portuguese) for the following files:

  • content/pt/ecosystem/registry/_index.md
  • content/pt/ecosystem/registry/adding.md
  • content/pt/ecosystem/registry/updating.md

@vitorvasc vitorvasc marked this pull request as ready for review February 10, 2025 11:46
@vitorvasc vitorvasc requested a review from a team as a code owner February 10, 2025 11:46
@opentelemetrybot opentelemetrybot requested review from a team February 10, 2025 11:46
maryliag
maryliag approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maryliag
Copy link
Contributor

tem teste falhando se você puder dar um olhada, antes de eu marcar que está pronto pra merge

@vitorvasc
Copy link
Member Author

tem teste falhando se você puder dar um olhada, antes de eu marcar que está pronto pra merge

Acredito que seja por conta da falta de fallbacks, pois algumas refs de links ainda não existem em português - e também não encontra a página original em inglês. 😓

Esses PRs que estão quebrando, acredito que estes pontos sejam corrigidos quando a #6273 esteja finalizada.

@maryliag
Copy link
Contributor

ah blz, quando estiver funcionando, ai eu marco aqui pros maintainers darem merge então

@chalin chalin force-pushed the pt_localize_ecosystem_registry branch from 306a583 to c139c66 Compare February 14, 2025 07:18
@opentelemetrybot opentelemetrybot requested a review from a team February 14, 2025 07:18
@chalin chalin self-assigned this Feb 14, 2025
chalin
chalin requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold since there are en level changes I need to make beyond setting up the fallback pages

@chalin chalin mentioned this pull request Feb 14, 2025
Merged
@chalin chalin force-pushed the pt_localize_ecosystem_registry branch from d6b9144 to c02bf14 Compare February 14, 2025 16:10
@opentelemetrybot opentelemetrybot requested review from a team February 14, 2025 16:11
chalin
chalin approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off hold since #6320 has been merged. All checks are green now so I will approve & schedule for merge. 🙌🏻

@vitorvasc - content/pt/ecosystem/registry/_index.md has now drifted, and the new page contains important changes, so if you could address it soon, that would be appreciated.

@chalin chalin merged commit b0117bb into open-telemetry:main Feb 14, 2025
18 checks passed
This was referenced Feb 14, 2025
Open
Closed
@vitorvasc vitorvasc deleted the pt_localize_ecosystem_registry branch February 17, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

@chalin chalin chalin approved these changes

Assignees

@chalin chalin

Labels
lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorvasc @maryliag @chalin