Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Move registry search-form alert into registry page #6336

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[i18n] Move registry search-form alert into registry page #6336

merged 1 commit into from
Feb 17, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 15, 2025

  • Contributes to Improved i18n support #4467
  • Moves the alert from the registry search-form shortcode into the page where it is used. This will make it possible for the alert text to be localized more easily.
  • There is no change to the generated site files.

/cc @vitorvasc

@chalin chalin added i18n Internationalization and localization lang:pt labels Feb 15, 2025
@chalin chalin requested a review from a team as a code owner February 15, 2025 11:50
@chalin chalin mentioned this pull request Feb 15, 2025
Open
54 tasks
@chalin chalin force-pushed the chalin-im-reg-alert-out-of-shortcode-2025-02-15 branch from 13d7bbf to bc70892 Compare February 15, 2025 12:25
@chalin chalin force-pushed the chalin-im-reg-alert-out-of-shortcode-2025-02-15 branch from bc70892 to 1304e92 Compare February 17, 2025 16:32
@vitorvasc vitorvasc mentioned this pull request Feb 17, 2025
Merged
@vitorvasc
Copy link
Member

vitorvasc commented Feb 17, 2025 •
edited
Loading

Added the localization of this content on #6361.

Should the localization be here? Or can we merge this first and then use the #6361 to update the Portuguese localization + fix the redirect issue?

@chalin chalin added this pull request to the merge queue Feb 17, 2025
@chalin
Copy link
Contributor Author

chalin commented Feb 17, 2025

Will merge this first. You can then rebase and update your PR. Thx

Merged via the queue into open-telemetry:main with commit fd873ed Feb 17, 2025
18 checks passed
@chalin chalin deleted the chalin-im-reg-alert-out-of-shortcode-2025-02-15 branch February 17, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
i18n Internationalization and localization lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @vitorvasc @svrnm