[i18n] Make instrumentation-intro shortcode a simple include
#6364
+53
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
a team
and removed request for
a team
chalin
force-pushed
the
chalin-im-refactor-shortcodes-for-i18n-2025-02-17
branch
2 times, most recently
from
8c06808 to
a97823d
Compare
cartermp
approved these changes
Feb 18, 2025
chalin
force-pushed
the
chalin-im-refactor-shortcodes-for-i18n-2025-02-17
branch
from
f89f21e to
ed6f3b1
Compare
|
Thanks for the review @cartermp. |
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentation-intro.mdshortcode into a regular markdown file, included via the new includes shortcode. This way we can enable all the regular text, markdown, and i18n checks (for drift etc.). This is done for the following languages that had ainstrumentation-intro.mdshortcode:enesptincludeinstead of a shortcode.includeofinstrumentation-intro.mdwill be populated with the locale's version of the include. Is this ok with you @open-telemetry/docs-es-approvers @open-telemetry/docs-pt-approvers? It might be a bit strange (and we might need to modify the page-not-translated banner text), but I think that this is be best way moving forward.(If we agree to edit the page-not-translated text, I'll do that in a followup PR. I'd probably just add a qualifier like: "... not yet been fully translated ...")(I've added the qualifier "fully" to the banner text in this PR.)/xx/_includeswith:Preview: