Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] check-i18n: add support for drifted_from_default field #6444

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 28, 2025

  • A first contribution to [i18n] Add banner to non-en pages that have drifted #6443
  • Adds support to scripts/check-i18n.sh of a new flag -D, which will add a (~) boolean page-has-drifted front-matter field so that it can eventually be used to post a banner.
  • No change to generated site files, nor any net change to the GH actions (no new checks enabled yet)

@chalin chalin added CI/infra CI & infrastructure i18n Internationalization and localization labels Feb 28, 2025
@chalin chalin requested a review from a team as a code owner February 28, 2025 15:36
@chalin chalin force-pushed the chalin-im-rw-i18n-drift-status-2025-02-26 branch from 99d6147 to 316c49c Compare February 28, 2025 16:52
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin merged commit 51ec793 into open-telemetry:main Feb 28, 2025
18 checks passed
@chalin chalin deleted the chalin-im-rw-i18n-drift-status-2025-02-26 branch February 28, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n Internationalization and localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants