Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Display page-outdated banner for non-en pages that have drifted #6475

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 5, 2025

Previews

Screenshots (corresponding to the pages above)

Note

The banner illustrated next has a <details> element, which is show in its expanded form.

image
image

@chalin chalin added CI/infra CI & infrastructure i18n Internationalization and localization labels Mar 5, 2025
@chalin chalin requested a review from a team as a code owner March 5, 2025 20:25
@opentelemetrybot opentelemetrybot requested review from a team March 5, 2025 20:25
@chalin chalin force-pushed the chalin-im-page-drifted-banner-2025-02-20 branch from 20a3191 to 408c6bc Compare March 5, 2025 20:32
@chalin chalin removed the lang:ja label Mar 5, 2025
@chalin chalin removed the request for review from a team March 5, 2025 20:34
@opentelemetrybot opentelemetrybot requested a review from a team March 5, 2025 20:34
@chalin chalin changed the title [i18n] Display a page-may-be-outdated banner [i18n] Display a page-outdated banner for non-en pages that have drifted Mar 5, 2025
@chalin chalin changed the title [i18n] Display a page-outdated banner for non-en pages that have drifted [i18n] Display page-outdated banner for non-en pages that have drifted Mar 5, 2025
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin merged commit 2b1fe58 into open-telemetry:main Mar 5, 2025
18 checks passed
@chalin chalin deleted the chalin-im-page-drifted-banner-2025-02-20 branch March 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n Internationalization and localization lang:ja
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants