Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of What-is-OTel and Instrumentation pages #6487

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 6, 2025

@chalin chalin added the copyedit label Mar 6, 2025
@chalin chalin requested a review from a team as a code owner March 6, 2025 22:04
@chalin chalin force-pushed the chalin-im-rw-what-is-otel-2025-03-06 branch from fe57dfb to e0561d7 Compare March 6, 2025 22:07
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and typo fixes — thanks!

applications or systems, no matter their language, infrastructure, or runtime
environment. The storage and visualization of telemetry is intentionally left
to other tools.
- An **[observability] framework and toolkit** designed to facilitate the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use bold for emphasis, but I'm not über-opposed to it at the moment.

@chalin
Copy link
Contributor Author

chalin commented Mar 7, 2025

@theletterf - thank you for the careful review and suggestions. I've committed them all. I've left the bold emphasis for now.

@chalin
Copy link
Contributor Author

chalin commented Mar 7, 2025

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13723444959

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin chalin force-pushed the chalin-im-rw-what-is-otel-2025-03-06 branch from 64d4b93 to 68f91e7 Compare March 7, 2025 15:08
@chalin chalin merged commit bacce67 into open-telemetry:main Mar 7, 2025
18 checks passed
@chalin chalin deleted the chalin-im-rw-what-is-otel-2025-03-06 branch March 7, 2025 15:16
@chalin chalin mentioned this pull request Mar 7, 2025
6 tasks
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants