Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust getting started #6515

Merged
merged 24 commits into from
Mar 14, 2025

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Mar 11, 2025

Fixed #6503 #4365 #5745

Modify the getting started to match the latest OTel Rust release (0.28)
It only shows tracing signal (as before).

Mostly copied from existing example in the repo : https://github.com/open-telemetry/opentelemetry-rust/tree/main/examples

@cijothomas cijothomas requested a review from a team as a code owner March 11, 2025 00:57
@opentelemetrybot opentelemetrybot requested a review from a team March 11, 2025 00:57
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also love the console output being better than the JSON object.

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13816746876

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cartermp cartermp enabled auto-merge March 12, 2025 17:13
@cijothomas
Copy link
Member Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13826175163

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cijothomas
Copy link
Member Author

@cartermp Is the automation capable of fixing the merge conflicts it introduced? or is it expected that the contributor(me) will fix the conflict?

@svrnm
Copy link
Member

svrnm commented Mar 14, 2025

@cijothomas I assume you didn't touch the pt/ja files? Can you rebase your PR, that often helps with a situation like that

@cartermp cartermp added this pull request to the merge queue Mar 14, 2025
Merged via the queue into open-telemetry:main with commit 94e3141 Mar 14, 2025
19 checks passed
@cijothomas cijothomas deleted the cijothomas/rust-start-1 branch March 14, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Demo code not working properly
10 participants