Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translated contributing/pr-checks into ja #6529

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Mar 12, 2025

I translated contributing/pr-checks into ja.

preivew https://deploy-preview-6529--opentelemetry.netlify.app/ja/docs/contributing/pr-checks/.

I remain some of headers (like MARKDOWN linter, SPELLING check and so on) English because their name are names of github actions steps.

@opentelemetrybot opentelemetrybot requested a review from a team March 12, 2025 00:18
@opentelemetrybot opentelemetrybot requested a review from a team March 12, 2025 00:18
@Msksgm Msksgm force-pushed the ja/contributing/pr-checks branch 2 times, most recently from e2693d7 to b5615b1 Compare March 12, 2025 00:22
@Msksgm Msksgm marked this pull request as ready for review March 12, 2025 00:29
@Msksgm Msksgm requested a review from a team as a code owner March 12, 2025 00:29
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 12, 2025
@ymotongpoo
Copy link
Contributor

@Msksgm thanks for the contribution. the decision to keep headers in English makes sense in this blog context.

@Msksgm Msksgm force-pushed the ja/contributing/pr-checks branch from b5615b1 to 71840c4 Compare March 12, 2025 01:23
@opentelemetrybot opentelemetrybot requested a review from a team March 12, 2025 01:24
@chalin chalin added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 12, 2025
@chalin chalin added this pull request to the merge queue Mar 12, 2025
Merged via the queue into open-telemetry:main with commit 10334b8 Mar 12, 2025
18 checks passed
@Msksgm Msksgm deleted the ja/contributing/pr-checks branch March 13, 2025 21:24
cijothomas pushed a commit to cijothomas/opentelemetry.io that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants