Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for @WithSpan params. #6543

Merged
merged 9 commits into from
Mar 14, 2025
Merged

Add docs for @WithSpan params. #6543

merged 9 commits into from
Mar 14, 2025

Conversation

breedx-splk
Copy link
Contributor

The documentation for Java's @WithSpan annotation currently omits the kind (SpanKind control) parameter. With the upcoming 2.14.0 release, we're also gaining another parameter (inheritContext)...so this seemed like a good opportunity to document them both.

@breedx-splk breedx-splk requested a review from a team as a code owner March 13, 2025 17:09
@opentelemetrybot opentelemetrybot requested review from a team March 13, 2025 17:09
@breedx-splk breedx-splk mentioned this pull request Mar 13, 2025
Merged
theletterf
theletterf approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time no see, hermano! :)

LGTM. Approving.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13840585474

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13840585474.

@theletterf
Copy link
Member

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13840714126

@opentelemetrybot
Copy link
Collaborator

fix:refcache was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@opentelemetrybot opentelemetrybot requested a review from a team March 14, 2025 08:18
@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13852645164

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13853451677

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@opentelemetrybot opentelemetrybot requested review from a team March 14, 2025 09:23
@theletterf theletterf enabled auto-merge March 14, 2025 09:54
@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13854126777

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13854207609

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf theletterf added this pull request to the merge queue Mar 14, 2025
Merged via the queue into open-telemetry:main with commit d66e836 Mar 14, 2025
18 checks passed
cijothomas pushed a commit to cijothomas/opentelemetry.io that referenced this pull request Mar 14, 2025
@breedx-splk @opentelemetrybot
@theletterf @cijothomas
Add docs for @WithSpan params. (open-telemetry#6543)
8cf79ed 
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees
No one assigned
Labels
lang:ja lang:pt sig:java
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breedx-splk @theletterf @opentelemetrybot @jaydeluca