-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nudge to PR actions #6578
base: main
Are you sure you want to change the base?
Add nudge to PR actions #6578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! ✨
Have you tested this locally? I did, and the rerun request doesn't seem to be doing anything in GH (see inline comment for details):
$ gh run rerun $RUNID
✓ Requested rerun of run 13966456806
Edit: reruns seem to get created, but they (1) don't seem to be picking up the latest commits to the branch; (2) the status of the rerun checks don't appear on the PR itself.
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13969072963 |
fix:format failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13969072963. |
@chalin I reviewed the action and went for a simpler approach, that is, creating and pushing an empty commit on demand. As we squash commits when merging PRs, this adds no noise to the git history of |
This PR adds a
/nudge
action that relies ongh run rerun
: https://cli.github.com/manual/gh_run_rerunThe idea is addressing the need for rerunning checks after a
/fix
command. I wonder if adding this command at the end of all fix commands could also solve the situation.Might potentially fix #4339