Skip to content

[editorial] Adjust link into in-toto attestation spec #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 16, 2025

As I work on

I hit a 404 for the following link (the link is valid, but not in the way that it gets processed by the website scripts, but that's secondary -- bare with me :):

          The full [hash value (see glossary)](https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-5.pdf),
          of the built attestation. Some envelopes in the software attestation
          space also refer to this as the [digest](https://github.com/in-toto/attestation/blob/main/spec/README.md#in-toto-attestation-framework-spec).

Regardless, the link for "digest" is into the spec in general. The spec has no entry for "digest", hence I suggest just linking to the spec and mentioning "digest" as a term. See the proposed change in the PR for the full details.

/cc @svrnm @tiffany76 @theletterf

@chalin chalin requested review from a team as code owners January 16, 2025 17:46
@chalin chalin requested a review from a team as a code owner January 16, 2025 17:50
@joaopgrassi joaopgrassi added editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. Skip Changelog Label to skip the changelog check labels Jan 17, 2025
@trask trask merged commit 4ede341 into open-telemetry:main Jan 17, 2025
14 checks passed
@chalin chalin deleted the chalin-im-rw-in-toto-link-fix-2025-01-16 branch January 17, 2025 15:55
lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants