Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused old markdown link check #1993

Merged
merged 2 commits into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
THIS FILE IS AUTOGENERATED. DO NOT MODIFY MANUALLY!
See CONTRIBUTING.md for instructions to add an entry.
##################################################### -->
<!-- markdown-link-check-disable -->

# Changelog

Expand Down
3 changes: 0 additions & 3 deletions docs/database/database-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,12 @@ Database spans MUST follow the overall [guidelines for span names](https://githu

The **span name** SHOULD be `{db.query.summary}` if a summary is available.

<!-- markdown-link-check-disable -->
<!-- HTML anchors are not supported https://github.com/tcort/markdown-link-check/issues/225-->
If no summary is available, the span name SHOULD be `{db.operation.name} {target}`
provided that a (low-cardinality) `db.operation.name` is available (see below for
the exact definition of the [`{target}`](#target-placeholder) placeholder).

If a (low-cardinality) `db.operation.name` is not available, database span names
SHOULD default to the [`{target}`](#target-placeholder).
<!-- markdown-link-check-enable -->

If neither `{db.operation.name}` nor `{target}` are available, span name SHOULD be `{db.system}`.

Expand Down
3 changes: 0 additions & 3 deletions docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,7 @@ HTTP spans MUST follow the overall [guidelines for span names](https://github.co

HTTP span names SHOULD be `{method} {target}` if there is a (low-cardinality) `target` available. If there is no (low-cardinality) `{target}` available, HTTP span names SHOULD be `{method}`.

<!-- markdown-link-check-disable -->
<!-- HTML anchors are not supported https://github.com/tcort/markdown-link-check/issues/225-->
(see below for the exact definition of the [`{method}`](#method-placeholder) and [`{target}`](#target-placeholder) placeholders).
<!-- markdown-link-check-enable -->

The <span id="method-placeholder">`{method}`</span> MUST be `{http.request.method}` if the method represents the original method known to the instrumentation.
In other cases (when `{http.request.method}` is set to `_OTHER`), `{method}` MUST be `HTTP`.
Expand Down
3 changes: 0 additions & 3 deletions docs/messaging/messaging-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,8 @@ in such a way that it cannot be changed by intermediaries.

Messaging spans SHOULD follow the overall [guidelines for span names](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.42.0/specification/trace/api.md#span).

<!-- markdown-link-check-disable -->
<!-- HTML anchors are not supported https://github.com/tcort/markdown-link-check/issues/225-->
The **span name** SHOULD be `{messaging.operation.name} {destination}`
(see below for the exact definition of the [`{destination}`](#destination-placeholder) placeholder).
<!-- markdown-link-check-enable -->

Semantic conventions for individual messaging systems MAY specify different
span name format and then MUST document it in semantic conventions
Expand Down
2 changes: 1 addition & 1 deletion docs/system/hardware-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Please note that this is an [ongoing process](https://github.com/open-telemetry/
- [`hw.voltage.` - Voltage sensor metrics](#hwvoltage---voltage-sensor-metrics)

> **Warning**
> Existing instrumentations and collector that are using<!-- markdown-link-check-disable-next-line -->
> Existing instrumentations and collector that are using
> [v1.21.0 of this document](https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/system/hardware-metrics.md)
> (or prior):
>
Expand Down
2 changes: 1 addition & 1 deletion docs/system/process-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ metrics](/docs/runtime/README.md#metrics).

<!-- tocstop -->

> **Warning** Existing instrumentations and collector that are using<!-- markdown-link-check-disable-next-line -->
> **Warning** Existing instrumentations and collector that are using
> [v1.21.0 of this document](https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/system/process-metrics.md)
> (or prior):
>
Expand Down
2 changes: 1 addition & 1 deletion docs/system/system-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Resource attributes related to a host, SHOULD be reported under the `host.*` nam

<!-- tocstop -->

> **Warning** Existing instrumentations and collector that are using<!-- markdown-link-check-disable-next-line -->
> **Warning** Existing instrumentations and collector that are using
> [v1.21.0 of this document](https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/system/system-metrics.md)
> (or prior):
>
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"test": "npm run check"
},
"devDependencies": {
"markdown-link-check": "3.11.2",
"markdown-toc": "^1.2.0",
"markdownlint-cli": "0.44.0",
"prettier": "^3.0.0"
Expand Down
Loading