Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Add document for SVC API#1039

Open
starwarfan wants to merge 3 commits into
open-webrtc-toolkit:masterfrom
starwarfan:mst-svc-doc
Open

Add document for SVC API#1039
starwarfan wants to merge 3 commits into
open-webrtc-toolkit:masterfrom
starwarfan:mst-svc-doc

Conversation

@starwarfan

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread doc/Client-Portal Protocol.md Outdated
mid: string(MID),
from: string(TrackID) | string(StreamID),
parameters: object(VideoParametersSpecification) | undefined,
preferredLayers: { // Used to force layers for SVC stream

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we move this to parameters above? And the same shall be shared by subscription control singaling.

@starwarfan starwarfan Jul 9, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My consideration is that the preferredLayers may have conflict with parameters.resolution or parameters.framerate. For example, spatial layer 0 and resolution 720p may not align. Placing it outside parameters can mean that it will override parameters.
Besides, I have no idea about describing the parameters of an SVC stream yet. Because an SVC stream may have multiple resolutions. I'll use highest layers for parameters so far.

Comment thread doc/servermd/RESTAPI.md Outdated
transcoding: object(Transcoding), // the transcoding control
notifying: object(Notifying), // notification control
selectActiveAudio: boolean, // select 3 most active audio streams for the room
senderBandwidthEstimation: boolean, // enable send side bandwidth estimation

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be part of webrtc agent configuration instead of room configuration.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, ok to put this as part of room configuration.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change its name to webrtcSenderSideBandwidthEstimation? This configuration doesn't work for WebTransport connections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants