Skip to content

Fix: App crash when entered amount exceeds 100,000 in Receive Money screen #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul31124 wants to merge 3 commits into
base: dev
Choose a base branch
from
+39 −18
Open

Fix: App crash when entered amount exceeds 100,000 in Receive Money screen #2005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ceed82
fix(qr): prevent app crash when entered amount exceeds maximum limit
rahul31124 Apr 11, 2026
04b7b18
resolve conflicts and clear invalid amount on error
rahul31124 Jun 6, 2026
7fe7947
resolve remaining conflicts
rahul31124 Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion feature/mpay-qr/src/commonMain/kotlin/org/mifospay/feature/mpay/qr/MpayQrScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ internal fun MpayQrScreen(
MpayQrEvent.OnNavigateBack -> navigateBack.invoke()
MpayQrEvent.QrDownloaded -> snackbarHostState.showSnackbar(downloadedMessage)
is MpayQrEvent.ShowSnackbar -> {
clipboardManager.setText(AnnotatedString(event.message))
snackbarHostState.showSnackbar(event.message)
}

is MpayQrEvent.CopyToClipboard -> {
clipboardManager.setText(AnnotatedString(event.text))
snackbarHostState.showSnackbar(copiedMessage)
}
}
Expand Down Expand Up @@ -292,6 +296,7 @@ private fun MpayQrScreenContent(
modifier = Modifier.padding(horizontal = KptTheme.spacing.sm),
)
}

1 -> {
// Inter-Bank - show QR or placeholder
if (contentState.interBankData != null) {
Expand Down
50 changes: 33 additions & 17 deletions feature/mpay-qr/src/commonMain/kotlin/org/mifospay/feature/mpay/qr/MpayQrViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,12 @@ class MpayQrViewModel(
}
}

is MpayQrAction.ShowSnackbar -> {
sendEvent(MpayQrEvent.ShowSnackbar(action.message))
}

is MpayQrAction.CopyToClipboard -> {
sendEvent(MpayQrEvent.ShowSnackbar(action.text))
sendEvent(MpayQrEvent.CopyToClipboard(action.text))
}

is MpayQrAction.ShowAccountPicker -> {
Expand Down Expand Up @@ -320,26 +324,36 @@ class MpayQrViewModel(

private fun initiateSetAmount() {
viewModelScope.launch {
val intraBankData = withContext(ioDispatcher) {
MpayQrCodeProcessor.encodeMpayString(state.qrData)
}
try {
val intraBankData = withContext(ioDispatcher) {
MpayQrCodeProcessor.encodeMpayString(state.qrData)
}

val interBankData = if (state.accountExternalId.isNotBlank()) {
withContext(ioDispatcher) {
MpayQrCodeProcessor.encodeMpayString(state.interBankQrData)
val interBankData = if (state.accountExternalId.isNotBlank()) {
withContext(ioDispatcher) {
MpayQrCodeProcessor.encodeMpayString(state.interBankQrData)
}
} else {
null
}
} else {
null
}

updateContent {
it.copy(
intraBankData = intraBankData,
interBankData = interBankData,
)
}
updateContent {
it.copy(
intraBankData = intraBankData,
interBankData = interBankData,
)
}

mutableStateFlow.update { it.copy(dialogState = null) }
mutableStateFlow.update { it.copy(dialogState = null) }
} catch (e: IllegalArgumentException) {
mutableStateFlow.update {
it.copy(
dialogState = null,
qrData = it.qrData.copy(amount = ""),
)
}
sendEvent(MpayQrEvent.ShowSnackbar(e.message ?: "Invalid amount entered"))
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
}

Expand Down Expand Up @@ -510,6 +524,7 @@ sealed interface MpayQrEvent {
data object OnNavigateBack : MpayQrEvent
data object QrDownloaded : MpayQrEvent
data class ShowSnackbar(val message: String) : MpayQrEvent
data class CopyToClipboard(val text: String) : MpayQrEvent
}

sealed interface MpayQrAction {
Expand Down Expand Up @@ -559,6 +574,7 @@ sealed interface MpayQrAction {
}
}

data class ShowSnackbar(val message: String) : MpayQrAction
data class CopyToClipboard(val text: String) : MpayQrAction

sealed interface Internal : MpayQrAction {
Expand Down
Loading