Skip to content

Conversation

@JaySoni1
Copy link
Contributor

Replaced custom methods in *.ts files that were previously using SavingService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JaySoni1
Copy link
Contributor Author

@gkbishnoi07 Please Review

@gkbishnoi07
Copy link
Collaborator

Okay

@steinwinde
Copy link
Collaborator

@gkbishnoi07 , I assume that your comment means that you are still reviewing this? I don't want to appear pushy - just want to make sure I understand your comment.

@gkbishnoi07
Copy link
Collaborator

image

cannot create saving account getting error

Copy link
Collaborator

@gkbishnoi07 gkbishnoi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test your PR first

@JaySoni1 JaySoni1 force-pushed the WEB-340-replace-custom-api-of-saving-service-ts branch from 402472b to f087bcc Compare November 3, 2025 22:53
@JaySoni1
Copy link
Contributor Author

JaySoni1 commented Nov 3, 2025

@gkbishnoi07 I have update the PR please review .

@JaySoni1 JaySoni1 requested a review from gkbishnoi07 November 4, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants