Allow the user to specify which openMINDS version should be used by Collection.load()
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Collection.load()`. By default, uses the most recent release.
| from .base import Link | ||
|
|
||
|
|
||
| DEFAULT_VERSION = "v4" |
Member
There was a problem hiding this comment.
Maybe instead of using a constant here, it would be better to automatically select the latest version, excluding "latest" itself.
Member
Author
There was a problem hiding this comment.
yes, that would be better. I propose to leave this for a future pull request.
| newly_sorted.append(node_id) | ||
| unsorted -= set(newly_sorted) | ||
| return [self.nodes[node_id] for node_id in sorted] | ||
|
|
Member
There was a problem hiding this comment.
An empty line seems to be missing.
Member
Author
There was a problem hiding this comment.
no, I don't think so. I think it's just that GitHub doesn't show a line if the file ends with a linebreak
Raphael-Gazzotti
approved these changes
Nov 17, 2025
Raphael-Gazzotti
merged commit 2248509
into
openMetadataInitiative:pipeline
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, uses the most recent release.
This is an alternative to #75.
The disadvantage of the approach in this PR is that the user needs to know which version of openMINDS was used to create the loaded file(s), which is fine if they created the files themselves, but a problem if someone else created them (e.g., a curator handling files generated by a data provider).
The advantages of this approach are (i) it avoids filling JSON-LD files with a lot of "schema:schemaVersion" entries, and (ii) it ensures all nodes are read with the same schema version. (The approach in #75 in theory opens the door to having a graph combining different openMINDS versions, which we probably don't want to do).