Conversation
ycedres
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's a follow up fix for regression caused by #782
Upstream PR saltstack/salt#70231 will be updated with the same fix.
What issues does this PR fix or reference?
Upstream PR: saltstack/salt#70231
Previous Behavior
State works as expected, but the verification after installing the package fails on comparing the version of installed package and requested if the requested one has no release part specified. For example with
= 1.2.3, the verification will fail if installed1.2.3-1.1.New Behavior
Returning to the previous behaviour we had before #782 while having strict check of the version with no ignoring release if omitted for one of two versions specified for comparison for
salt.utils.pkg.rpm.version_cmp.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.