Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.71.2 → 1.73.2 (minor) #1610

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 18, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.71.2 → 1.73.2) · Repo · Changelog

Release Notes

1.73.2

Bug fixes

  • #13942: Fix incorrect disabling of departments when inheriting configuration. (@koic)
  • #13766: Fix false positives for Style/InverseMethods when using any? or none? with safe navigation operator. (@koic)
  • #13938: Fix false positives for Style/RedundantCondition when a variable or a constant is used. (@koic)
  • #13935: Fix a false negative for Style/RedundantFreeze when calling methods that produce frozen objects with numblocks. (@earlopain)
  • #13928: Fix end pattern with unmatched parenthesis: / (RegexpError) on Ruby 3.2.0. (@dvandersluis)
  • #13933: Fix wrong autocorrect for Style/KeywordParametersOrder when the arguments are on multiple lines and contain comments. (@earlopain)

Changes

1.73.1

Bug fixes

  • #13920: Fix an error for Lint/MixedCaseRange when /[[ ]]/ is used. (@koic)
  • #13912: Fix wrong autocorrect for Lint/EmptyConditionalBody when assigning to a variable with only a single branch. (@earlopain)
  • #13913: Fix false positives for Style/RedundantCondition when using when true is used as the true branch and the condition is not a predicate method. (@koic)
  • #13909: Fix false positive with Layout/ClosingParenthesisIndentation when first parameter is a hash. (@tejasbubane)
  • #13915: Fix writing generics type of rbs-inline annotation for nested class in Style/CommentedKeyword. (@dak2)
  • #13916: Fix Lint/LiteralAsCondition acting on the right hand side of && nodes. (@zopolis4)

1.73.0

New features

  • #11024: Add require_always option to Style/EndlessMethod. (@koic)
  • #11024: Add require_single_line option to Style/EndlessMethod. (@jtannas)
  • #9935: Introduce EnforcedStyleForMultiline "diff_comma". (@flavorjones)

Bug fixes

  • #13867: Fix an error for plugins when not running RuboCop through Bundler. (@earlopain)
  • #13902: Fix false negative for Style/RedundantSelfAssignment when the method receives a block. (@vlad-pisanov)
  • #13826: Fix false positives for regex cops when Lint/MixedCaseRange is enabled. (@earlopain)
  • #13818: Fix false positives for Lint/Void when using operator method call without argument. (@koic)
  • #13896: Fix a false positive for Style/TrivialAccessors with instance_eval and numblocks. (@earlopain)
  • #13910: Fix false positives for Style/EndlessMethod when using setter method definitions. (@koic)
  • #13889: Fix autocorrection for Layout/LineLength with interpolated strings when not on the first line. (@dvandersluis)
  • #13900: Fix infinite loop between Layout/EmptyLinesAroundAccessModifier and Layout/EmptyLinesAroundBlockBody with EnforcedStyle: no_empty_lines. (@dvandersluis)
  • #12692: Fix Style/AccessorGrouping with constants. (@tejasbubane)
  • #13882: Fix Style/RedundantFormat for annotated template strings with missing hash keys. (@dvandersluis)
  • #13880: Fix Style/RedundantFormat when given double-splatted arguments. (@dvandersluis)
  • #13907: Don't offer autocorrect for Style/StringConcatenation when numblocks are used. (@earlopain)
  • #13876: Don't consider require 'pp' to be redundant for Lint/RedundantRequireStatement. (@earlopain)
  • #13885: Update Style/HashExcept and Style/HashSlice to not register an offense if selecting over the hash value. (@dvandersluis)

Changes

  • #12948: Add ForbiddenNames configuration to Naming/VariableName to specify names that are forbidden. (@dvandersluis)
  • #13117: Add partial autocorrect support to Lint/LiteralAsCondition cop to check for redundant conditions. (@zopolis4)
  • #13892: Allow merging of configured arrays and non-arrays. (@sambostock)
  • #13833: Add Reference to common params. (@sambostock)
  • #13890: Update Lint/RedundantTypeConversion to not register an offense when given a constructor with exception: false. (@dvandersluis)
  • #13729: Update Style/RedundantCondition cop to detect conditional expressions where the true branch is true and suggest replacing them with a logical OR. (@datpmt)

1.72.2

Bug fixes

  • #13853: Fix exclusion of relative paths in plugin's AllCops: Exclude as expected. (@koic)
  • #13844: Fix an error for Style/RedundantFormat when a template argument is used without keyword arguments. (@koic)
  • #13857: Fix an error for Style/RedundantFormat when numeric placeholders is used in the template argument. (@koic)
  • #13861: Fix ArgumentError related to two deprecated AllowedPattern APIs. (@koic)
  • #13849: Fix an error for Lint/UselessConstantScoping when multiple assigning to constants after private access modifier. (@koic)
  • #13856: Fix false positives for Lint/UselessConstantScoping when a constant is used after private access modifier with arguments. (@koic)

Changes

  • #13846: Mark Style/RedundantFormat as unsafe autocorrect. (@koic)

1.72.1

Bug fixes

  • #13836: Fix an error for Style/RedundantParentheses when a different expression appears before a range literal. (@koic)
  • #13839: Fix false positives for Lint/RedundantTypeConversion when passing block arguments when generating a Hash or a Set. (@koic)

Changes

  • #13839: Extension plugin is loaded automatically with require 'rubocop/rspec/support'. (@koic)

1.72.0

New features

  • #13740: Add new Lint/CopDirectiveSyntax cop. (@kyanagi)
  • #13800: Add new Lint/SuppressedExceptionInNumberConversion cop. (@koic)
  • #13702: Add new Lint/RedundantTypeConversion cop. (@dvandersluis)
  • #13831: Add new Lint/UselessConstantScoping cop. (@koic)
  • #13793: Add new Style/RedundantFormat cop to check for uses of format or sprintf with only a single string argument. (@dvandersluis)
  • #13581: Add new InternalAffairs/LocationExists cop to check for code that can be replaced with Node#loc? or Node#loc_is?. (@dvandersluis)
  • #13661: Make server mode detect local paths in .rubocop.yml under inherit_from and require for automatically restart. (@koic)
  • #13721: Naming/PredicateName: Optionally use Sorbet to detect predicate methods. (@issyl0)
  • #6012: Support RuboCop extension plugin. (@koic)

Bug fixes

  • #13807: Fix false negatives for Style/RedundantParentheses when chaining [] method calls. (@koic)
  • #13788: Fix false negatives for Style/RedundantParentheses when [] method is called with variable or constant receivers. (@koic)
  • #13811: Fix false negatives for Style/RedundantParentheses when handling range literals with redundant parentheses. (@koic)
  • #13796: Fix crash in Layout/EmptyLinesAroundMethodBody for endless methods. (@dvandersluis)
  • #13817: Fix false positive for format specifier with non-numeric precision. (@dvandersluis)
  • #12672: Fix false positives for Lint/FormatParameterMismatch when the width value is interpolated. (@dvandersluis)
  • #12795: Fix Layout/BlockAlignment for blocks that are the body of an endless method. (@dvandersluis)
  • #13822: Fix undefined method Logger when processing watched file notifications. (@vinistock)
  • #13805: Make the language_server-protocol dependency version stricter. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.38.0 → 1.39.0) · Repo · Changelog

Release Notes

1.39.0 (from changelog)

New features

  • #359: Enable reusable Prism parse result. (@koic)

1.38.1 (from changelog)

Bug fixes

  • #360: Fix an error when the Array core class contains a writer method before rubocop-ast loaded. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 16 commits:

🆕 lint_roller (added, 1.1.0)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 18, 2025
Copy link
Contributor Author

depfu bot commented Apr 2, 2025

Closed in favor of #1613.

@depfu depfu bot closed this Apr 2, 2025
@depfu depfu bot deleted the depfu/update/rubocop-1.73.2 branch April 2, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants