doc: clarify --quiet for needs-rebooting is a global option - #657
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
The needs-rebooting section told users to "use --quiet to suppress the normal output" right after describing the command, which reads as a command specific flag. zypper needs-rebooting --quiet actually fails with "The flag --quiet is not known", since --quiet is only a global option and must come before the command name, per issue openSUSE#610. Point that out explicitly instead of leaving it ambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #610
The man page's
needs-rebootingsection says "Use --quiet to suppress the normal output" right after describing the command, which reads like a command specific flag. Runningzypper needs-rebooting --quietactually fails with "The flag --quiet is not known", sinceneeds-rebootingdefines no command specific options at all (confirmed insrc/commands/needs-rebooting.cc,cmdOptions()returns an emptyCommandGroup).--quietis a global option (src/Config.cc) and, per the GLOBAL OPTIONS section itself, must be given before the command name.Verified no other subcommand in
src/commands/defines its own local--quiet, so the man page's wording was the actual bug, not the missing flag. Reworded the sentence to say--quietis the global option and must come before the command name, matching how other sections of the same man page reference global options (e.g.--ignore-unknown global option,--releasever global option).Docs only, no code change.