-
Notifications
You must be signed in to change notification settings - Fork 3
Hat tv2 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Hat tv2 #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive technical documentation for the openUC2 Raspberry Pi HAT+ v2 (FRAME Controller), providing detailed specifications, integration guides, and bring-up procedures for the hardware.
Key Changes
- New 496-line technical documentation covering HAT+ v2 hardware specifications
- Detailed electrical architecture, communication interfaces, and safety features
- Complete ESP32 pinout configuration code for firmware integration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| *(Locations and effects annotated in CAN / power / USB-UART sheets.)* | ||
|
|
||
|
|
||
| ### 18 Pinout |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section numbering is inconsistent. Section 18 appears after section 16.3, skipping section 17. This should be renumbered to '### 16.4 Pinout' to maintain sequential ordering within the appendix.
| ### 18 Pinout | |
| ### 16.4 Pinout |
| #define DIAL_CONTROLLER 1 | ||
| #define MOTOR_CONTROLLER 1 | ||
| #define HOME_MOTOR 1 | ||
| #define BTHID 1 |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace after the value '1'. Remove the extra space for consistency with other macro definitions.
| #define BTHID 1 | |
| #define BTHID 1 |
I got to line 21. There are a lot of errors in the rest of the text
|
I got to line 21 correcting its errors and irrelevancies before I got pissed off. The generated document is very long and unfocused. It repeats a bunch of stuff multiple times, without extra information. It gets stuff wrong and imprecise, and of course it talks about not-implemented functions. Then, the name for the document is wrong - it should follow Hardware revisions and the current one is Rev. D. What should I do with this?
I'll scroll through the document some more. |
|
|
||
| ## 13) Known errata / revisions | ||
|
|
||
| * Early revisions: **HAT EEPROM I²C** issues due to header **SCL miswire**; workaround was bodge-wire. Ensure your board rev has corrected routing before relying on auto-detect. *(Design note captured in bring-up comments.)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you got communiation with the EEPROMs working with the bodge? Because I haven't. I'll try communicating with the EEPROMs some more.
|
I absolutely get your point! We can rewrite the docs from scratch focussing on what's most relevant. For me it's crucial:
The pinout for the v2 you have provided I guess in a PR on the UC2-ESP repo. |
|
Here's my wishlist from the ImSwitch OS side:
|
|
@christiankuttke would you mind having a look at the configuration file Ethan created? Does it look complete to you? |
Are you referring to the config file snippet we added and tested together in a pair-programming session in openUC2/rpi-imswitch-os#48 ? |
|
@christiankuttke the colour code is: camera in opto pin 2 => yellow, camera gnd opto pin 5 => white. |

Hey @christiankuttke, these are suggestions for the docs for the HAT - they are mostly AI generated and I know you don't like that but maybe this is a first start for the real docs. I need help with the pinout and I gues @ethanjli needs input for the I2C-based setting of the high-current mode ;)