-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fix toasts on Windows under WSL 2 #7137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution. We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback. |
|
@dank-openai, there are some CI failures. Looks like simple lint ( |
4c885a3 to
50f90ac
Compare
|
@dank-openai, one more CI failure to fix — this time a code formatting issue in a docs file ( |
6235c49 to
457cc81
Compare
|
@dank-openai, looks like there's a merge conflict now. Can you resolve? |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
457cc81 to
9857bac
Compare
9857bac to
e1ae4ec
Compare
|
@dank-openai, just wanted to give you an update on this PR. The codex team member who is most familiar with this part of the code case is away this week for the Thanksgiving holidays. I've asked him to review it when he's back at work next week. |
Before this: no notifications or toasts when using Codex CLI in WSL 2.
After this: I get toasts from Codex