Skip to content

Conversation

@dank-openai
Copy link
Contributor

Before this: no notifications or toasts when using Codex CLI in WSL 2.

After this: I get toasts from Codex

@etraut-openai
Copy link
Collaborator

Thanks for the contribution. We've updated our contribution guidelines to clarify that we're currently accepting contributions for bugs and security fixes, but we're not generally accepting new features at this time. We need to make sure that all new features compose well with both existing and upcoming features and fit into our roadmap. If you would like to propose a new feature, please file or upvote an enhancement request in the issue tracker. We will generally prioritize new features based on community feedback.

@etraut-openai
Copy link
Collaborator

@dank-openai, there are some CI failures. Looks like simple lint (cargo clippy) issues — should be easy to fix.

@dank-openai dank-openai force-pushed the dank/pr/windows_toast branch from 4c885a3 to 50f90ac Compare November 24, 2025 16:14
@etraut-openai
Copy link
Collaborator

@dank-openai, one more CI failure to fix — this time a code formatting issue in a docs file (prettier).

@etraut-openai etraut-openai added the needs-response Additional information is requested label Nov 24, 2025
@dank-openai dank-openai force-pushed the dank/pr/windows_toast branch from 6235c49 to 457cc81 Compare November 24, 2025 19:55
@etraut-openai etraut-openai removed the needs-response Additional information is requested label Nov 24, 2025
@etraut-openai
Copy link
Collaborator

@dank-openai, looks like there's a merge conflict now. Can you resolve?

@etraut-openai
Copy link
Collaborator

@codex review

@etraut-openai etraut-openai added the needs-response Additional information is requested label Nov 24, 2025
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dank-openai dank-openai force-pushed the dank/pr/windows_toast branch from 457cc81 to 9857bac Compare November 24, 2025 20:40
@dank-openai dank-openai force-pushed the dank/pr/windows_toast branch from 9857bac to e1ae4ec Compare November 24, 2025 21:03
@etraut-openai etraut-openai removed the needs-response Additional information is requested label Nov 24, 2025
@dank-openai dank-openai enabled auto-merge (squash) November 25, 2025 16:24
@etraut-openai
Copy link
Collaborator

@dank-openai, just wanted to give you an update on this PR. The codex team member who is most familiar with this part of the code case is away this week for the Thanksgiving holidays. I've asked him to review it when he's back at work next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants