Skip to content

Conversation

@seratch
Copy link
Member

@seratch seratch commented Oct 31, 2025

This pull request aims to resolve #2007; this approach may look like a kind of workaround, which might should be done on the openai pakcage side, but if 3rd party integrations (e.g., commonly used proxy library of openai for monitoring etc.) do not expect the new omit object to come, removing them on the Agents SDK side should make sense at least in the short term. We may want to do the same for Responses API, but I'd like to hold off doing so for now.

@seratch seratch requested a review from rm-openai October 31, 2025 04:28
@seratch seratch added bug Something isn't working feature:chat-completions labels Oct 31, 2025
Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but this completely removes the typechecking of the method so don't want to do it this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature:chat-completions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError object of type 'Omit' has no len()

3 participants